You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: resolve MCP service modal checkbox double-click event issue (#5790)
Fixed the issue where clicking on checkboxes in the MCP service modal
would trigger double-click events, causing selections to be immediately
deselected.
Root cause:
- Checkbox onChange events were conflicting with parent HStack onClick events
- Both components were trying to handle the same selection logic
Solution:
- Extracted handleItemClick function to avoid code duplication
- Flex onClick: only e.stopPropagation() to prevent event bubbling
- Checkbox onChange: handleItemClick for checkbox-specific interactions
- HStack onClick: handleItemClick for row-level interactions
Benefits:
✅ Checkbox clicks work properly without double-toggle
✅ Full row click functionality preserved
✅ All checkbox hover/focus effects maintained
✅ Clean DRY code structure with shared logic
✅ Perfect visual alignment between checkbox and avatar
Changes made to:
- projects/app/src/pageComponents/dashboard/mcp/EditModal.tsx:159-194
🤖 Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)
Co-authored-by: Claude <[email protected]>
Co-authored-by: Happy <[email protected]>
0 commit comments