refactor: capture loop variables to avoid closure issues in goroutines

Signed-off-by: cuisongliu <[email protected]>

Author: cuisongliu

lifecycle/pkg/apply/applydrivers/apply_drivers_default.go

@@ -337,6 +337,7 @@ func (c *Applier) syncWorkdir() {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, ipAddr := range ipList {
+		ipAddr := ipAddr
 		eg.Go(func() error {
 			return execer.Copy(ipAddr, workDir, workDir)
 		})

lifecycle/pkg/apply/processor/create.go

@@ -121,6 +121,7 @@ func (c *CreateProcessor) RunConfig(cluster *v2.Cluster) error {
 	logger.Info("Executing pipeline RunConfig in CreateProcessor.")
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, cManifest := range cluster.Status.Mounts {
+		cManifest := cManifest
 		eg.Go(func() error {
 			cfg := config.NewConfiguration(
 				cManifest.ImageName,

lifecycle/pkg/apply/processor/delete.go

@@ -115,6 +115,7 @@ func (d *DeleteProcessor) UnMountRootfs(cluster *v2.Cluster) error {
 func (d *DeleteProcessor) UnMountImage(cluster *v2.Cluster) error {
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, mount := range cluster.Status.Mounts {
+		mount := mount
 		eg.Go(func() error {
 			return d.Buildah.Delete(mount.Name)
 		})

lifecycle/pkg/apply/processor/install.go

@@ -240,6 +240,7 @@ func (c *InstallProcessor) RunConfig(_ *v2.Cluster) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, cManifest := range c.NewMounts {
+		cManifest := cManifest
 		eg.Go(func() error {
 			cfg := config.NewConfiguration(
 				cManifest.ImageName,

lifecycle/pkg/apply/processor/scale.go

@@ -264,6 +264,7 @@ func (c *ScaleProcessor) RunConfig(cluster *v2.Cluster) error {
 	logger.Info("Executing pipeline RunConfig in ScaleProcessor.")
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, cManifest := range cluster.Status.Mounts {
+		cManifest := cManifest
 		eg.Go(func() error {
 			cfg := config.NewConfiguration(
 				cManifest.ImageName,

lifecycle/pkg/buildah/manifest.go

@@ -988,7 +988,7 @@ func manifestInspect(
 		if latestErr == nil {
 			latestErr = e
 		} else {
-			latestErr = fmt.Errorf("tried %w: %w", e, latestErr)
+			latestErr = fmt.Errorf("tried %v: %w", e, latestErr)
 		}
 	}