NO_PROXY is incorrectly validated

[maria-oleszkiewicz]

When NO_PROXY is set to localhost,127.0.0.1 which is correct value on Linux it fails with:

(py311) mariaoleszkiewicz@MacBookPro Documents % python test.py
Traceback (most recent call last):
  File "/Users/mariaoleszkiewicz/Documents/test.py", line 36, in <module>
    watsonx_llm = WatsonxLLM(
                  ^^^^^^^^^^^
  File "/Users/mariaoleszkiewicz/miniforge3/envs/py311/lib/python3.11/site-packages/langchain_core/load/serializable.py", line 125, in __init__
    super().__init__(*args, **kwargs)
  File "/Users/mariaoleszkiewicz/miniforge3/envs/py311/lib/python3.11/site-packages/pydantic/main.py", line 214, in __init__
    validated_self = self.__pydantic_validator__.validate_python(data, self_instance=self)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for WatsonxLLM
  Value error, Unknown scheme for proxy URL URL('localhost,127.0.0.1') [type=value_error, input_value={'model_id': 'mistralai/m...0, 'min_new_tokens': 1}}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.10/v/value_error

Setting NO_PROXY=http://127.0.0.1 fixes it, but the export NO_PROXY=localhost,127.0.0.1 should be accepted as well.

[MateuszOssGit]

Based on the error message Value error, Unknown scheme for proxy URL URL('localhost,127.0.0.1'), the issue appears to be with the proxy URL format rather than an error in the validation logic. A proper URL consists of several components, including:

• Scheme: The protocol to be used (e.g., http:// or https://).
• Subdomain: An optional part of the domain, such as www..
• Domain Name: The main part of the host, for example, example.
• Top-level Domain: The domain extension, such as co.uk or com.

In this case, the provided proxy URL localhost,127.0.0.1 is improperly formatted as it lacks a valid scheme and does not adhere to the standard URL structure. Please update the proxy URL to a valid format (e.g., http://localhost or http://127.0.0.1) to resolve the issue.

In my view, no modifications are necessary for the langchain_ibm package.

[arne-kapell]

I think there might me a misconception here. The no_proxy environment variable usually holds a list of hosts, not URLs.
I say usually, because there is no standardised spec for this variable (see https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/). But while there are differences in support for things like CIDR ranges, I have never seen something containing a protocol there.
So to summarise my view: there is something wrong with the validation logic as it tries to validate no_proxy to hold an URL when it really holds a list of hosts (separated by ,). I think this should be validated for instead.

[MateuszOssGit]

@arne-kapell Package with fix has been released (ibm-watsonx-ai 1.3.3) and is available on pypi -> https://pypi.org/project/ibm-watsonx-ai/1.3.3/

If error still exist could you please provide snippet code demonstrating step-by-step?

@maria-oleszkiewicz Could you please validate and close if error do not exist more?

[Mateusz-Switala]

Closing because the problem no longer exists.