CallBeforeCreating event in eloquent factory

[victor-priceputu]

Hello,
When the factories for models are used, make saves the relationships the model is dependent on and set in the definition, but not the current model. This in a way makes sense, because how else would you potentially have the IDs for those models.

The issue I have is that I need the relations to not be saved (the project I am working on is using UUIDs as IDs, and they are manually generated, plus we do not have a database for unit tests, only for feature tests because 'best practice, you should not need one for unit tests'), and I need a relationship in a post save event which breaks all tests.

We are using the factories everywhere, and would like to be able to easily set the relation in the factory, to ensure we always have data integrity, and not have to manually set in every test.

For this I would like to request a new callback, similar to afterMaking and afterCreating that is only called in create, but after the call to make, basically right before

framework/src/Illuminate/Database/Eloquent/Factories/Factory.php

Line 308 in 2c682e4

$this->store(new Collection([$results]));

and

framework/src/Illuminate/Database/Eloquent/Factories/Factory.php

Line 312 in 2c682e4

$this->store($results);

before the calls to store, to allow more data manipulation to be done between make and create, in preparation for things like saving events.

I know this wall of text may not make much sense, please feel free to ask for clarifications.

Thank you

[macropay-solutions]

Basically you need to modify the code base just to be able to unit test? If yes then you have precedent and it could be implemented. We saw code in laravel written just for unit tests that is useless in production.

[victor-priceputu]

not necessarily, I had to go through every test and change things to make it work, and I realise that maybe not many would have this issue, but I see this as a potentially useful improvement