@@ -31,10 +31,11 @@ func TestRequestorImplRequestAll(t *testing.T) {
3131 httphelpers .WithServer (handler , func (ts * httptest.Server ) {
3232 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , ts .URL , filter .key )
3333
34- data , cached , err := r .Request ()
34+ data , cached , headers , err := r .Request ()
3535
3636 assert .NoError (t , err )
3737 assert .False (t , cached )
38+ assert .NotEmpty (t , headers )
3839
3940 assert .Equal (t , sharedtest .NormalizeDataSet (expectedData .Build ()), sharedtest .NormalizeDataSet (data ))
4041
@@ -49,14 +50,15 @@ func TestRequestorImplRequestAll(t *testing.T) {
4950 httphelpers .WithServer (handler , func (ts * httptest.Server ) {
5051 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , ts .URL , filter .key )
5152
52- data , cached , err := r .Request ()
53+ data , cached , headers , err := r .Request ()
5354
5455 assert .Error (t , err )
5556 if he , ok := err .(httpStatusError ); assert .True (t , ok ) {
5657 assert .Equal (t , 500 , he .Code )
5758 }
5859 assert .False (t , cached )
5960 assert .Nil (t , data )
61+ assert .NotEmpty (t , headers )
6062 })
6163 })
6264
@@ -68,37 +70,40 @@ func TestRequestorImplRequestAll(t *testing.T) {
6870 })
6971 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , closedServerURL , filter .key )
7072
71- data , cached , err := r .Request ()
73+ data , cached , headers , err := r .Request ()
7274
7375 assert .Error (t , err )
7476 assert .False (t , cached )
7577 assert .Nil (t , data )
78+ assert .Nil (t , headers )
7679 })
7780
7881 t .Run ("malformed data" , func (t * testing.T ) {
7982 handler := httphelpers .HandlerWithResponse (200 , nil , []byte ("{" ))
8083 httphelpers .WithServer (handler , func (ts * httptest.Server ) {
8184 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , ts .URL , filter .key )
8285
83- data , cached , err := r .Request ()
86+ data , cached , headers , err := r .Request ()
8487
8588 require .Error (t , err )
8689 _ , ok := err .(malformedJSONError )
8790 assert .True (t , ok )
8891 assert .False (t , cached )
8992 assert .Nil (t , data )
93+ assert .NotEmpty (t , headers )
9094 })
9195 })
9296
9397 t .Run ("malformed base URI" , func (t * testing.T ) {
9498 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , "::::" , filter .key )
9599
96- data , cached , err := r .Request ()
100+ data , cached , headers , err := r .Request ()
97101
98102 require .Error (t , err )
99103 assert .Contains (t , err .Error (), "missing protocol scheme" )
100104 assert .False (t , cached )
101105 assert .Nil (t , data )
106+ assert .Nil (t , headers )
102107 })
103108
104109 t .Run ("sends configured headers" , func (t * testing.T ) {
@@ -113,7 +118,7 @@ func TestRequestorImplRequestAll(t *testing.T) {
113118 httphelpers .WithServer (handler , func (ts * httptest.Server ) {
114119 r := NewPollingRequester (context , nil , ts .URL , filter .key )
115120
116- _ , _ , err := r .Request ()
121+ _ , _ , _ , err := r .Request ()
117122 assert .NoError (t , err )
118123
119124 req := <- requestsCh
@@ -130,7 +135,7 @@ func TestRequestorImplRequestAll(t *testing.T) {
130135 httphelpers .WithServer (handler , func (ts * httptest.Server ) {
131136 r := NewPollingRequester (context , nil , ts .URL , filter .key )
132137
133- _ , _ , err := r .Request ()
138+ _ , _ , _ , err := r .Request ()
134139 assert .NoError (t , err )
135140
136141 assert .Equal (t , []string {"Polling LaunchDarkly for feature flag updates" },
@@ -159,10 +164,11 @@ func TestRequestorImplCaching(t *testing.T) {
159164 httphelpers .WithServer (handler , func (ts * httptest.Server ) {
160165 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , ts .URL , filter .key )
161166
162- data1 , cached1 , err1 := r .Request ()
167+ data1 , cached1 , headers1 , err1 := r .Request ()
163168
164169 assert .NoError (t , err1 )
165170 assert .False (t , cached1 )
171+ assert .NotEmpty (t , headers1 )
166172 assert .Equal (t , sharedtest .NormalizeDataSet (expectedData .Build ()), sharedtest .NormalizeDataSet (data1 ))
167173
168174 req1 := <- requestsCh
@@ -171,10 +177,11 @@ func TestRequestorImplCaching(t *testing.T) {
171177
172178 assert .Equal (t , "" , req1 .Request .Header .Get ("If-None-Match" ))
173179
174- data2 , cached2 , err2 := r .Request ()
180+ data2 , cached2 , headers2 , err2 := r .Request ()
175181
176182 assert .NoError (t , err2 )
177183 assert .True (t , cached2 )
184+ assert .NotEmpty (t , headers2 )
178185 assert .Nil (t , data2 ) // for cached data, requestAll doesn't bother parsing the body
179186
180187 req2 := <- requestsCh
@@ -196,7 +203,7 @@ func TestRequestorImplCanUseCustomHTTPClientFactory(t *testing.T) {
196203 httphelpers .WithServer (pollHandler , func (ts * httptest.Server ) {
197204 r := NewPollingRequester (context , nil , ts .URL , "" )
198205
199- _ , _ , _ = r .Request ()
206+ _ , _ , _ , _ = r .Request ()
200207
201208 req := <- requestsCh
202209
@@ -212,7 +219,7 @@ func TestRequestorImplCanAppendsFilterParameter(t *testing.T) {
212219 httphelpers .WithServer (pollHandler , func (ts * httptest.Server ) {
213220 r := NewPollingRequester (sharedtest .BasicClientContext (), nil , ts .URL , filter .key )
214221
215- _ , _ , _ = r .Request ()
222+ _ , _ , _ , _ = r .Request ()
216223
217224 req := <- requestsCh
218225
0 commit comments