fix: Remove deprecated track generation event (#301)

Author: jsonbailey

ldai/README.md

@@ -39,12 +39,12 @@ aiClient, err := ldai.NewClient(sdkClient)
 
 Fetch a model configuration for a specific LaunchDarkly context:
 ```go
-// The default value 'ldai.Disabled()' be returned if LaunchDarkly is unavailable or the config 
+// The default value 'ldai.Disabled()' be returned if LaunchDarkly is unavailable or the config
 // cannot be fetched. To customize the default value, use ldai.NewConfig().
 config, tracker := aiClient.Config("your-model-key", ldcontext.New("user-key"), ldai.Disabled(), nil)
 
 // Access the methods on config, and optionally use the returned tracker to generate analytic events
-// related to usage of the model config. 
+// related to usage of the model config.
 ```
 Learn more
 -----------
@@ -56,7 +56,7 @@ You can also head straight to the [complete reference guide for this SDK](https:
 Contributing
 ------------
 
-We encourage pull requests and other contributions from the community. Check out our [contributing guidelines](CONTRIBUTING.md) for instructions on how to contribute to this library.
+We encourage pull requests and other contributions from the community. Check out our [contributing guidelines](../CONTRIBUTING.md) for instructions on how to contribute to this library.
 
 About LaunchDarkly
 -----------

ldai/tracker.go

@@ -14,7 +14,6 @@ const (
 	duration          = "$ld:ai:duration:total"
 	feedbackPositive  = "$ld:ai:feedback:user:positive"
 	feedbackNegative  = "$ld:ai:feedback:user:negative"
-	generation        = "$ld:ai:generation"
 	generationSuccess = "$ld:ai:generation:success"
 	generationError   = "$ld:ai:generation:error"
 	//nolint:gosec
@@ -219,24 +218,14 @@ func (t *Tracker) TrackFeedback(feedback Feedback) error {
 func (t *Tracker) TrackSuccess() error {
 	t.success = ldcommon.Some(true)
 
-	err := t.events.TrackMetric(generation, t.context, 1, t.trackData)
-	if err := t.events.TrackMetric(generationSuccess, t.context, 1, t.trackData); err != nil {
-		return err
-	}
-
-	return err
+	return t.events.TrackMetric(generationSuccess, t.context, 1, t.trackData)
 }
 
 // TrackError tracks an unsuccessful model evaluation.
 func (t *Tracker) TrackError() error {
 	t.success = ldcommon.Some(false)
 
-	err := t.events.TrackMetric(generation, t.context, 1, t.trackData)
-	if err := t.events.TrackMetric(generationError, t.context, 1, t.trackData); err != nil {
-		return err
-	}
-
-	return err
+	return t.events.TrackMetric(generationError, t.context, 1, t.trackData)
 }
 
 // TrackTimeToFirstToken tracks the time to the first token of the streamed response.

ldai/tracker_test.go

@@ -64,12 +64,6 @@ func TestTracker_TrackSuccess(t *testing.T) {
 	assert.NoError(t, tracker.TrackSuccess())
 
 	expectedEvents := []trackEvent{
-		{
-			name:        "$ld:ai:generation",
-			context:     ldcontext.New("key"),
-			metricValue: 1.0,
-			data:        makeTrackData("key", "variationKey", 1, config),
-		},
 		{
 			name:        "$ld:ai:generation:success",
 			context:     ldcontext.New("key"),
@@ -88,12 +82,6 @@ func TestTracker_TrackError(t *testing.T) {
 	assert.NoError(t, tracker.TrackError())
 
 	expectedEvents := []trackEvent{
-		{
-			name:        "$ld:ai:generation",
-			context:     ldcontext.New("key"),
-			metricValue: 1.0,
-			data:        makeTrackData("key", "variationKey", 2, config),
-		},
 		{
 			name:        "$ld:ai:generation:error",
 			context:     ldcontext.New("key"),
@@ -128,12 +116,6 @@ func TestTracker_TrackRequest(t *testing.T) {
 	assert.Equal(t, expectedResponse, r)
 
 	expectedEvents := []trackEvent{
-		{
-			name:        "$ld:ai:generation",
-			context:     ldcontext.New("key"),
-			metricValue: 1,
-			data:        makeTrackData("key", "variationKey", 3, config),
-		},
 		{
 			name:        "$ld:ai:generation:success",
 			context:     ldcontext.New("key"),
@@ -214,8 +196,8 @@ func TestTracker_LatencyMeasuredIfNotProvided(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, expectedResponse, r)
 
-	require.Equal(t, 4, len(events.events))
-	gotEvent := events.events[2]
+	require.Equal(t, 3, len(events.events))
+	gotEvent := events.events[1]
 	assert.Equal(t, "$ld:ai:duration:total", gotEvent.name)
 	assert.Equal(t, 42.0, gotEvent.metricValue)
 }