Add error message for broken response status line (#242)

* Add test to reproduce #241

* Add error message for broken response status line

Fixes #241

* Add test for an explicit error message string

See #241

Author: Invizory

lib/resty/http.lua

@@ -362,7 +362,21 @@ local function _receive_status(sock)
         return nil, nil, nil, err
     end
 
-    return tonumber(str_sub(line, 10, 12)), tonumber(str_sub(line, 6, 8)), str_sub(line, 14)
+    local version = tonumber(str_sub(line, 6, 8))
+    if not version then
+        return nil, nil, nil,
+               "couldn't parse HTTP version from response status line: " .. line
+    end
+
+    local status = tonumber(str_sub(line, 10, 12))
+    if not status then
+        return nil, nil, nil,
+               "couldn't parse status code from response status line: " .. line
+    end
+
+    local reason = str_sub(line, 14)
+
+    return status, version, reason
 end
 
 

t/01-basic.t

@@ -341,3 +341,51 @@ OK
 --- no_error_log
 [error]
 [warn]
+
+=== TEST 13: Should return error on invalid HTTP version in response status line
+--- http_config eval: $::HttpConfig
+--- config
+    location = /a {
+        content_by_lua_block {
+            local http = require "resty.http"
+            local httpc = http.new()
+            local res, err = httpc:request_uri("http://127.0.0.1:12345")
+
+            assert(err == "couldn't parse HTTP version from response status line: TEAPOT/1.1 OMG")
+        }
+    }
+--- tcp_listen: 12345
+--- tcp_reply
+TEAPOT/1.1 OMG
+Server: Teapot
+
+OK
+--- request
+GET /a
+--- no_error_log
+[error]
+[warn]
+
+=== TEST 14: Should return error on invalid status code in response status line
+--- http_config eval: $::HttpConfig
+--- config
+    location = /a {
+        content_by_lua_block {
+            local http = require "resty.http"
+            local httpc = http.new()
+            local res, err = httpc:request_uri("http://127.0.0.1:12345")
+
+            assert(err == "couldn't parse status code from response status line: HTTP/1.1 OMG")
+        }
+    }
+--- tcp_listen: 12345
+--- tcp_reply
+HTTP/1.1 OMG
+Server: Teapot
+
+OK
+--- request
+GET /a
+--- no_error_log
+[error]
+[warn]