Skip to content

Commit a18b2c9

Browse files
committed
Correct post-update action comment on claims from closed chans
Before e938ed7 and 41f703c, when we had a payment preimage for a claim which needed to go to a closed channel, we'd always run the post-`ChannelMonitorUpdate` completion action immediately as we didn't actually track async `ChannelMonitorUpdate`s to closed channels. Since those commits we do, but the comment noting the completion action processing was not updated. Thus, here we update the comment, for the easiest close on a major feature issue ever. Fixes #2355.
1 parent 61e5819 commit a18b2c9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lightning/src/ln/channelmanager.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8381,11 +8381,11 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
83818381
channel_id: Some(prev_hop.channel_id),
83828382
};
83838383

8384-
// Note that we do process the completion action here. This totally could be a
8385-
// duplicate claim, but we have no way of knowing without interrogating the
8386-
// `ChannelMonitor` we've provided the above update to. Instead, note that `Event`s are
8387-
// generally always allowed to be duplicative (and it's specifically noted in
8388-
// `PaymentForwarded`).
8384+
// We don't have any idea if this is a duplicate claim without interrogating the
8385+
// `ChannelMonitor`, so we just always queue up the completion action after the
8386+
// `ChannelMonitorUpdate` we're about to generate. This may result in a duplicate `Event`,
8387+
// but note that `Event`s are generally always allowed to be duplicative (and it's
8388+
// specifically noted in `PaymentForwarded`).
83898389
let (action_opt, raa_blocker_opt) = completion_action(None, false);
83908390

83918391
if let Some(raa_blocker) = raa_blocker_opt {

0 commit comments

Comments
 (0)