Skip to content

Commit cfebc80

Browse files
committed
Remove #[rustfmt::skip] from fn write
Fixed formatting for write() in ChannelMonitorImpl. This would make the next commit cleaner by ensuring it only contains direct code shifts, without unrelated formatting changes.
1 parent 495912f commit cfebc80

File tree

1 file changed

+39
-18
lines changed

1 file changed

+39
-18
lines changed

lightning/src/chain/channelmonitor.rs

Lines changed: 39 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1357,7 +1357,6 @@ const SERIALIZATION_VERSION: u8 = 1;
13571357
const MIN_SERIALIZATION_VERSION: u8 = 1;
13581358

13591359
impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
1360-
#[rustfmt::skip]
13611360
fn write<W: Writer>(&self, writer: &mut W) -> Result<(), Error> {
13621361
write_ver_prefix!(writer, SERIALIZATION_VERSION, MIN_SERIALIZATION_VERSION);
13631362

@@ -1367,7 +1366,9 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
13671366
U48(self.commitment_transaction_number_obscure_factor).write(writer)?;
13681367

13691368
self.destination_script.write(writer)?;
1370-
if let Some(ref broadcasted_holder_revokable_script) = self.broadcasted_holder_revokable_script {
1369+
if let Some(ref broadcasted_holder_revokable_script) =
1370+
self.broadcasted_holder_revokable_script
1371+
{
13711372
writer.write_all(&[0; 1])?;
13721373
broadcasted_holder_revokable_script.0.write(writer)?;
13731374
broadcasted_holder_revokable_script.1.write(writer)?;
@@ -1430,58 +1431,77 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
14301431
}
14311432
}
14321433

1433-
writer.write_all(&(self.funding.counterparty_claimable_outpoints.len() as u64).to_be_bytes())?;
1434+
writer.write_all(
1435+
&(self.funding.counterparty_claimable_outpoints.len() as u64).to_be_bytes(),
1436+
)?;
14341437
for (ref txid, ref htlc_infos) in self.funding.counterparty_claimable_outpoints.iter() {
14351438
writer.write_all(&txid[..])?;
14361439
writer.write_all(&(htlc_infos.len() as u64).to_be_bytes())?;
14371440
for &(ref htlc_output, ref htlc_source) in htlc_infos.iter() {
1438-
debug_assert!(htlc_source.is_none() || Some(**txid) == self.funding.current_counterparty_commitment_txid
1441+
debug_assert!(
1442+
htlc_source.is_none()
1443+
|| Some(**txid) == self.funding.current_counterparty_commitment_txid
14391444
|| Some(**txid) == self.funding.prev_counterparty_commitment_txid,
1440-
"HTLC Sources for all revoked commitment transactions should be none!");
1445+
"HTLC Sources for all revoked commitment transactions should be none!"
1446+
);
14411447
serialize_htlc_in_commitment!(htlc_output);
14421448
htlc_source.as_ref().map(|b| b.as_ref()).write(writer)?;
14431449
}
14441450
}
14451451

1446-
writer.write_all(&(self.counterparty_commitment_txn_on_chain.len() as u64).to_be_bytes())?;
1452+
writer
1453+
.write_all(&(self.counterparty_commitment_txn_on_chain.len() as u64).to_be_bytes())?;
14471454
for (ref txid, commitment_number) in self.counterparty_commitment_txn_on_chain.iter() {
14481455
writer.write_all(&txid[..])?;
14491456
writer.write_all(&byte_utils::be48_to_array(*commitment_number))?;
14501457
}
14511458

14521459
writer.write_all(&(self.counterparty_hash_commitment_number.len() as u64).to_be_bytes())?;
1453-
for (ref payment_hash, commitment_number) in self.counterparty_hash_commitment_number.iter() {
1460+
for (ref payment_hash, commitment_number) in self.counterparty_hash_commitment_number.iter()
1461+
{
14541462
writer.write_all(&payment_hash.0[..])?;
14551463
writer.write_all(&byte_utils::be48_to_array(*commitment_number))?;
14561464
}
14571465

14581466
if let Some(holder_commitment_tx) = &self.funding.prev_holder_commitment_tx {
14591467
writer.write_all(&[1; 1])?;
14601468
write_legacy_holder_commitment_data(
1461-
writer, holder_commitment_tx, &self.prev_holder_htlc_data.as_ref().unwrap(),
1469+
writer,
1470+
holder_commitment_tx,
1471+
&self.prev_holder_htlc_data.as_ref().unwrap(),
14621472
)?;
14631473
} else {
14641474
writer.write_all(&[0; 1])?;
14651475
}
14661476

14671477
write_legacy_holder_commitment_data(
1468-
writer, &self.funding.current_holder_commitment_tx, &self.current_holder_htlc_data,
1478+
writer,
1479+
&self.funding.current_holder_commitment_tx,
1480+
&self.current_holder_htlc_data,
14691481
)?;
14701482

1471-
writer.write_all(&byte_utils::be48_to_array(self.current_counterparty_commitment_number))?;
1483+
writer
1484+
.write_all(&byte_utils::be48_to_array(self.current_counterparty_commitment_number))?;
14721485
writer.write_all(&byte_utils::be48_to_array(self.current_holder_commitment_number))?;
14731486

14741487
writer.write_all(&(self.payment_preimages.len() as u64).to_be_bytes())?;
14751488
for (payment_preimage, _) in self.payment_preimages.values() {
14761489
writer.write_all(&payment_preimage.0[..])?;
14771490
}
14781491

1479-
writer.write_all(&(self.pending_monitor_events.iter().filter(|ev| match ev {
1480-
MonitorEvent::HTLCEvent(_) => true,
1481-
MonitorEvent::HolderForceClosed(_) => true,
1482-
MonitorEvent::HolderForceClosedWithInfo { .. } => true,
1483-
_ => false,
1484-
}).count() as u64).to_be_bytes())?;
1492+
writer.write_all(
1493+
&(self
1494+
.pending_monitor_events
1495+
.iter()
1496+
.filter(|ev| match ev {
1497+
MonitorEvent::HTLCEvent(_) => true,
1498+
MonitorEvent::HolderForceClosed(_) => true,
1499+
MonitorEvent::HolderForceClosedWithInfo { .. } => true,
1500+
_ => false,
1501+
})
1502+
.count() as u64)
1503+
.to_be_bytes(),
1504+
)?;
14851505
for event in self.pending_monitor_events.iter() {
14861506
match event {
14871507
MonitorEvent::HTLCEvent(upd) => {
@@ -1505,7 +1525,8 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
15051525
self.best_block.block_hash.write(writer)?;
15061526
writer.write_all(&self.best_block.height.to_be_bytes())?;
15071527

1508-
writer.write_all(&(self.onchain_events_awaiting_threshold_conf.len() as u64).to_be_bytes())?;
1528+
writer
1529+
.write_all(&(self.onchain_events_awaiting_threshold_conf.len() as u64).to_be_bytes())?;
15091530
for ref entry in self.onchain_events_awaiting_threshold_conf.iter() {
15101531
entry.write(writer)?;
15111532
}
@@ -1533,7 +1554,7 @@ impl<Signer: EcdsaChannelSigner> Writeable for ChannelMonitorImpl<Signer> {
15331554
let mut pending_monitor_events = self.pending_monitor_events.clone();
15341555
pending_monitor_events.push(MonitorEvent::HolderForceClosed(*outpoint));
15351556
pending_monitor_events
1536-
}
1557+
},
15371558
_ => self.pending_monitor_events.clone(),
15381559
};
15391560

0 commit comments

Comments
 (0)