Skip to content

Commit 42b37ea

Browse files
firewalldb: remove speculative doc comments
This commit removes speculative comments from the firewalldb migration docs that forecast future implementations. Such comments can create confusion for developers looking at the current code base without knowing our plans how the migration will be further developed.
1 parent 11ca98b commit 42b37ea

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

firewalldb/sql_migration.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ func (e *kvEntry) namespacedKey() string {
7272
// transaction to ensure that all rows in the stores are migrated or none at
7373
// all.
7474
//
75-
// Note that this migration currently only migrates the kvstores, but will be
76-
// extended in the future to also migrate the privacy mapper and action stores.
77-
//
7875
// NOTE: As sessions may contain linked sessions and accounts, the sessions and
7976
// accounts sql migration MUST be run prior to this migration.
8077
func MigrateFirewallDBToSQL(ctx context.Context, kvStore *bbolt.DB,

firewalldb/sql_migration_test.go

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ type expectedResult struct {
4242
// TestFirewallDBMigration tests the migration of firewalldb from a bolt
4343
// backend to a SQL database. Note that this test does not attempt to be a
4444
// complete migration test.
45-
// This test only tests the migration of the KV stores currently, but will
46-
// be extended in the future to also test the migration of the privacy mapper
47-
// and the actions store in the future.
4845
func TestFirewallDBMigration(t *testing.T) {
4946
t.Parallel()
5047

@@ -218,9 +215,9 @@ func TestFirewallDBMigration(t *testing.T) {
218215
}
219216
}
220217

221-
// The assertMigrationResults function will currently assert that
222-
// the migrated kv stores records in the SQLDB match the original kv
223-
// stores records in the BoltDB.
218+
// The assertMigrationResults asserts that the migrated entries in the
219+
// firewall SQLDB match the expected results which should represent the
220+
// original entries in the BoltDB.
224221
assertMigrationResults := func(t *testing.T, sqlStore *SQLDB,
225222
expRes *expectedResult) {
226223

@@ -231,9 +228,6 @@ func TestFirewallDBMigration(t *testing.T) {
231228

232229
// The tests slice contains all the tests that we will run for the
233230
// migration of the firewalldb from a BoltDB to a SQLDB.
234-
// Note that the tests currently only test the migration of the KV
235-
// stores, but will be extended in the future to also test the migration
236-
// of the privacy mapper and the actions store.
237231
tests := []struct {
238232
name string
239233
populateDB func(t *testing.T, ctx context.Context,

0 commit comments

Comments
 (0)