Persist agreed quotes in RFQ service #1863

darioAnongba · 2025-11-03T14:45:33Z

RFQ buy/sell accepts are now written to the database (rfq_policies table) whenever a policy is agreed, giving us an audit trail and keeping quotes across restarts.

The OrderHandler reloads these rows at startup to rebuild policies and the manager repopulates its in-memory caches from the same data.

Added a check in itest that restarts Bob’s tapd mid RFQ flow and verifies the quote remains available to Carol.

Fixes #855

coveralls · 2025-11-03T15:11:22Z

Pull Request Test Coverage Report for Build 20035184886

Details

410 of 530 (77.36%) changed or added relevant lines in 8 files are covered.
8277 unchanged lines in 122 files lost coverage.
Overall coverage increased (+0.09%) to 56.735%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tapdb/sqlutils.go	22	28	78.57%
tapdb/sqlc/rfq.sql.go	53	61	86.89%
rfq/manager.go	11	23	47.83%
rfq/order.go	50	70	71.43%
tapdb/rfq_policies.go	263	337	78.04%

Files with Coverage Reduction	New Missed Lines	%
fn/context_guard.go	1	91.94%
authmailbox/client.go	2	66.67%
commitment/proof.go	2	87.29%
fn/retry.go	2	92.5%
tapdb/interfaces.go	2	78.33%
universe/interface.go	3	74.21%
commitment/encoding.go	4	68.75%
mssmt/encoding.go	4	76.67%
rpcutils/price_oracle_marshal.go	4	85.07%
tapsend/proof.go	4	85.99%

Totals
Change from base Build 20033169882:	0.09%
Covered Lines:	65264
Relevant Lines:	115034

💛 - Coveralls

coveralls · 2025-11-03T15:11:22Z

Pull Request Test Coverage Report for Build 19038516198

Details

425 of 603 (70.48%) changed or added relevant lines in 5 files are covered.
507 unchanged lines in 39 files lost coverage.
Overall coverage decreased (-0.3%) to 56.265%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rfq/manager.go	14	21	66.67%
tapdb/sqlc/rfq.sql.go	58	74	78.38%
rfq/order.go	28	72	38.89%
tapdb/rfq_policies.go	318	429	74.13%

Files with Coverage Reduction	New Missed Lines	%
proof/courier.go	1	78.88%
asset/asset.go	2	79.97%
asset/group_key.go	2	72.15%
fn/func.go	2	58.82%
tapdb/assets_common.go	2	77.97%
tapdb/migrations.go	2	76.19%
tapdb/sqlc/mssmt.sql.go	2	47.02%
tapdb/sqlc/transfers.sql.go	2	82.65%
tapdb/universe_federation.go	2	88.55%
tapdb/universe.go	2	80.35%

Totals
Change from base Build 18942913401:	-0.3%
Covered Lines:	64373
Relevant Lines:	114410

💛 - Coveralls

tapdb/rfq_policies.go

rfq/manager.go

rfq/manager_test.go

rfq/order.go

GeorgeTsagk

Just a few nits, will do a final pass soon

rfq/interface.go

rfq/order.go

GeorgeTsagk

Looking good, dropped a few more comments

rfq/manager.go

rfq/order.go

tapdb/rfq_policies.go

rfq/manager.go

rfq/order.go

rfq/manager.go

tapdb/rfq_policies.go

tapdb/sqlc/migrations/000049_rfq_policies.up.sql

tapdb/sqlc/queries/rfq.sql

ffranr

Just a few more trivial points to consider, otherwise this PR is pretty much there IMO.

rfq/interface.go

rfqmsg/buy_accept.go

rfqmsg/sell_accept.go

tapdb/sqlc/migrations/000049_rfq_policies.up.sql

tapdb/sqlc/schemas/generated_schema.sql

ffranr · 2025-12-03T17:25:53Z

rfq/order.go

+// QuoteID returns the RFQ identifier that originated this policy.
+func (c *AssetPurchasePolicy) QuoteID() (rfqmsg.ID, bool) {
+	return c.AcceptedQuoteId, true
+}


I don't think this is called anywhere so it can be removed here and in the Policy interface. I might be wrong. Why does this have a bool return value? We could use fn.Option perhaps? But I think this method can be removed.

true! Residue of the old implementation with active field. Removed.

rfq/manager.go

GeorgeTsagk

Looks good, some last optional nits provided below

rfqmsg/buy_accept.go

rfq/manager.go

rfq/order.go

Adds a new rfq_policies table and store allowing persistence of sale and purchase policies.

refactors the current quote in-memory storage away from the Manager into the OrderHandler to encapsulate all quote storage operations in the same component.

darioAnongba self-assigned this Nov 3, 2025

darioAnongba changed the base branch from main to 0-8-0-staging November 3, 2025 14:45

darioAnongba force-pushed the feat/persist-rfq branch from 3c33ca3 to f0acc02 Compare November 3, 2025 14:46

darioAnongba force-pushed the feat/persist-rfq branch 2 times, most recently from 98bcb62 to 5a2bd52 Compare November 3, 2025 15:17

darioAnongba marked this pull request as ready for review November 3, 2025 15:17

darioAnongba requested review from GeorgeTsagk, ffranr and jtobin November 3, 2025 15:18

levmi added this to Taproot-Assets Project Board Nov 3, 2025

github-project-automation bot moved this to 🆕 New in Taproot-Assets Project Board Nov 3, 2025

levmi moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Nov 3, 2025

levmi added this to the v0.8 milestone Nov 3, 2025

GeorgeTsagk reviewed Nov 5, 2025

View reviewed changes

tapdb/rfq_policies.go Outdated Show resolved Hide resolved

ffranr reviewed Nov 10, 2025

View reviewed changes

rfq/manager.go Outdated Show resolved Hide resolved

rfq/manager.go Outdated Show resolved Hide resolved

rfq/manager_test.go Outdated Show resolved Hide resolved

rfq/order.go Outdated Show resolved Hide resolved

rfq/order.go Outdated Show resolved Hide resolved

darioAnongba force-pushed the feat/persist-rfq branch from 5a2bd52 to f7ebd34 Compare November 11, 2025 16:54

darioAnongba requested a review from ffranr November 11, 2025 17:28

darioAnongba force-pushed the feat/persist-rfq branch from f7ebd34 to 703a103 Compare November 12, 2025 13:35

darioAnongba requested a review from GeorgeTsagk November 12, 2025 13:40

darioAnongba force-pushed the feat/persist-rfq branch 3 times, most recently from e74f4ab to 497b820 Compare November 13, 2025 21:16

darioAnongba force-pushed the 0-8-0-staging branch from 2b3ac4f to 035a840 Compare November 14, 2025 09:38

darioAnongba force-pushed the feat/persist-rfq branch from 497b820 to 7beb886 Compare November 14, 2025 09:40

GeorgeTsagk reviewed Nov 17, 2025

View reviewed changes

rfq/interface.go Show resolved Hide resolved

rfq/order.go Outdated Show resolved Hide resolved

darioAnongba moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Nov 17, 2025

GeorgeTsagk reviewed Nov 20, 2025

View reviewed changes

rfq/manager.go Outdated Show resolved Hide resolved

rfq/order.go Outdated Show resolved Hide resolved

rfq/order.go Outdated Show resolved Hide resolved

tapdb/rfq_policies.go Outdated Show resolved Hide resolved

darioAnongba force-pushed the feat/persist-rfq branch from 7beb886 to d223874 Compare November 24, 2025 10:11

darioAnongba changed the base branch from 0-8-0-staging to main November 24, 2025 10:11

darioAnongba requested a review from GeorgeTsagk November 24, 2025 10:27

darioAnongba force-pushed the feat/persist-rfq branch 2 times, most recently from 75b90ba to 9023608 Compare November 24, 2025 16:03

jtobin removed their request for review November 25, 2025 06:39

ffranr reviewed Dec 1, 2025

View reviewed changes

darioAnongba force-pushed the feat/persist-rfq branch from 9023608 to 0b0b19d Compare December 2, 2025 12:38

darioAnongba requested a review from ffranr December 2, 2025 13:07

ffranr reviewed Dec 3, 2025

View reviewed changes

GeorgeTsagk approved these changes Dec 4, 2025

View reviewed changes

rfqmsg/buy_accept.go Outdated Show resolved Hide resolved

rfq/manager.go Outdated Show resolved Hide resolved

rfq/order.go Show resolved Hide resolved

darioAnongba force-pushed the feat/persist-rfq branch from 0b0b19d to 521bafc Compare December 4, 2025 11:31

darioAnongba requested a review from ffranr December 4, 2025 11:31

darioAnongba force-pushed the feat/persist-rfq branch from 521bafc to 0fb9015 Compare December 4, 2025 11:47

jcbrand reviewed Dec 5, 2025

View reviewed changes

rfq/order.go Show resolved Hide resolved

ffranr approved these changes Dec 8, 2025

View reviewed changes

rfq/order.go Outdated Show resolved Hide resolved

rfq/order.go Outdated Show resolved Hide resolved

darioAnongba added 6 commits December 8, 2025 17:25

rfqmsg: add AgreedAt field to BuyAccept and SellAccept

66014f3

tapdb: add support for RFQ policy persistence.

8d73029

Adds a new rfq_policies table and store allowing persistence of sale and purchase policies.

rfq: add support for quote policy persistence and restoration

4735340

refactors the current quote in-memory storage away from the Manager into the OrderHandler to encapsulate all quote storage operations in the same component.

tapcfg: instantiate policyStore and inject in the rfq manager

4dd4837

itest: verify persistence of rfq policies across restarts

c86a022

docs: add release notes

15a5f3c

darioAnongba force-pushed the feat/persist-rfq branch from 0fb9015 to 15a5f3c Compare December 8, 2025 16:27

darioAnongba added this pull request to the merge queue Dec 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025

darioAnongba added this pull request to the merge queue Dec 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025

darioAnongba added this pull request to the merge queue Dec 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025

Persist agreed quotes in RFQ service #1863

Are you sure you want to change the base?

Persist agreed quotes in RFQ service #1863

Uh oh!

Conversation

darioAnongba commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 20035184886

Details

💛 - Coveralls

Uh oh!

coveralls commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19038516198

Details

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GeorgeTsagk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GeorgeTsagk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ffranr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ffranr Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darioAnongba Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GeorgeTsagk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

darioAnongba commented Nov 3, 2025 •

edited

Loading

coveralls commented Nov 3, 2025 •

edited

Loading

ffranr Dec 3, 2025 •

edited

Loading