Fix noctx linter errors

```
Error: cmd/lima-guestagent/daemon_linux.go:89:29: net.Listen must not be called. use (*net.ListenConfig).Listen (noctx)
  		socketL, err := net.Listen("unix", socket)
  		                          ^
Error: cmd/lima-guestagent/install_systemd_linux.go:69:22: os/exec.Command must not be called. use os/exec.CommandContext (noctx)
  		cmd := exec.Command("systemctl", append([]string{"--system"}, args...)...)
...  		                   ^
```

Signed-off-by: Akihiro Suda <[email protected]>

Author: AkihiroSuda

cmd/lima-guestagent/daemon_linux.go

@@ -32,6 +32,7 @@ func newDaemonCommand() *cobra.Command {
 }
 
 func daemonAction(cmd *cobra.Command, _ []string) error {
+	ctx := cmd.Context()
 	socket := "/run/lima-guestagent.sock"
 	tick, err := cmd.Flags().GetDuration("tick")
 	if err != nil {
@@ -86,7 +87,8 @@ func daemonAction(cmd *cobra.Command, _ []string) error {
 		l = vsockL
 		logrus.Infof("serving the guest agent on vsock port: %d", vSockPort)
 	} else {
-		socketL, err := net.Listen("unix", socket)
+		var lc net.ListenConfig
+		socketL, err := lc.Listen(ctx, "unix", socket)
 		if err != nil {
 			return err
 		}

cmd/lima-guestagent/install_systemd_linux.go

@@ -30,6 +30,7 @@ func newInstallSystemdCommand() *cobra.Command {
 }
 
 func installSystemdAction(cmd *cobra.Command, _ []string) error {
+	ctx := cmd.Context()
 	vsockPort, err := cmd.Flags().GetInt("vsock-port")
 	if err != nil {
 		return err
@@ -66,7 +67,7 @@ func installSystemdAction(cmd *cobra.Command, _ []string) error {
 		{"try-restart", "lima-guestagent.service"},
 	}
 	for _, args := range args {
-		cmd := exec.Command("systemctl", append([]string{"--system"}, args...)...)
+		cmd := exec.CommandContext(ctx, "systemctl", append([]string{"--system"}, args...)...)
 		cmd.Stdout = os.Stdout
 		cmd.Stderr = os.Stderr
 		logrus.Infof("Executing: %s", strings.Join(cmd.Args, " "))

cmd/limactl/copy.go

@@ -48,6 +48,7 @@ func newCopyCommand() *cobra.Command {
 }
 
 func copyAction(cmd *cobra.Command, args []string) error {
+	ctx := cmd.Context()
 	recursive, err := cmd.Flags().GetBool("recursive")
 	if err != nil {
 		return err
@@ -161,7 +162,7 @@ func copyAction(cmd *cobra.Command, args []string) error {
 	}
 	sshArgs := sshutil.SSHArgsFromOpts(sshOpts)
 
-	sshCmd := exec.Command(arg0, append(sshArgs, scpArgs...)...)
+	sshCmd := exec.CommandContext(ctx, arg0, append(sshArgs, scpArgs...)...)
 	sshCmd.Stdin = cmd.InOrStdin()
 	sshCmd.Stdout = cmd.OutOrStdout()
 	sshCmd.Stderr = cmd.ErrOrStderr()

cmd/limactl/hostagent.go

@@ -40,6 +40,7 @@ func newHostagentCommand() *cobra.Command {
 }
 
 func hostagentAction(cmd *cobra.Command, args []string) error {
+	ctx := cmd.Context()
 	pidfile, err := cmd.Flags().GetString("pidfile")
 	if err != nil {
 		return err
@@ -117,7 +118,8 @@ func hostagentAction(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return err
 	}
-	l, err := net.Listen("unix", socket)
+	var lc net.ListenConfig
+	l, err := lc.Listen(ctx, "unix", socket)
 	logrus.Infof("hostagent socket created at %s", socket)
 	if err != nil {
 		return err

cmd/limactl/shell.go

@@ -60,6 +60,7 @@ func newShellCommand() *cobra.Command {
 }
 
 func shellAction(cmd *cobra.Command, args []string) error {
+	ctx := cmd.Context()
 	// simulate the behavior of double dash
 	newArg := []string{}
 	if len(args) >= 2 && args[1] == "--" {
@@ -254,7 +255,7 @@ func shellAction(cmd *cobra.Command, args []string) error {
 		"--",
 		script,
 	}...)
-	sshCmd := exec.Command(sshExe.Exe, sshArgs...)
+	sshCmd := exec.CommandContext(ctx, sshExe.Exe, sshArgs...)
 	sshCmd.Stdin = os.Stdin
 	sshCmd.Stdout = os.Stdout
 	sshCmd.Stderr = os.Stderr

cmd/limactl/tunnel.go

@@ -47,6 +47,7 @@ func newTunnelCommand() *cobra.Command {
 }
 
 func tunnelAction(cmd *cobra.Command, args []string) error {
+	ctx := cmd.Context()
 	flags := cmd.Flags()
 	tunnelType, err := flags.GetString("type")
 	if err != nil {
@@ -108,7 +109,7 @@ func tunnelAction(cmd *cobra.Command, args []string) error {
 		"-p", strconv.Itoa(inst.SSHLocalPort),
 		inst.SSHAddress,
 	}...)
-	sshCmd := exec.Command(sshExe.Exe, sshArgs...)
+	sshCmd := exec.CommandContext(ctx, sshExe.Exe, sshArgs...)
 	sshCmd.Stdout = stderr
 	sshCmd.Stderr = stderr
 	logrus.Debugf("executing ssh (may take a long)): %+v", sshCmd.Args)

pkg/autostart/autostart.go

@@ -5,6 +5,7 @@
 package autostart
 
 import (
+	"context"
 	_ "embed"
 	"errors"
 	"fmt"
@@ -78,6 +79,7 @@ func GetFilePath(hostOS, instName string) string {
 }
 
 func enableDisableService(action, hostOS, serviceWithPath string) error {
+	ctx := context.TODO()
 	// Get filename without extension
 	filename := strings.TrimSuffix(path.Base(serviceWithPath), filepath.Ext(path.Base(serviceWithPath)))
 
@@ -97,7 +99,7 @@ func enableDisableService(action, hostOS, serviceWithPath string) error {
 			filename,
 		}...)
 	}
-	cmd := exec.Command(args[0], args[1:]...)
+	cmd := exec.CommandContext(ctx, args[0], args[1:]...)
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	return cmd.Run()

pkg/downloader/downloader_test.go

@@ -316,11 +316,12 @@ func TestDownloadCompressed(t *testing.T) {
 	}
 
 	t.Run("gzip", func(t *testing.T) {
+		ctx := t.Context()
 		localPath := filepath.Join(t.TempDir(), t.Name())
 		localFile := filepath.Join(t.TempDir(), "test-file")
 		testDownloadCompressedContents := []byte("TestDownloadCompressed")
 		assert.NilError(t, os.WriteFile(localFile, testDownloadCompressedContents, 0o644))
-		assert.NilError(t, exec.Command("gzip", localFile).Run())
+		assert.NilError(t, exec.CommandContext(ctx, "gzip", localFile).Run())
 		localFile += ".gz"
 		testLocalFileURL := "file://" + localFile
 
@@ -334,11 +335,12 @@ func TestDownloadCompressed(t *testing.T) {
 	})
 
 	t.Run("bzip2", func(t *testing.T) {
+		ctx := t.Context()
 		localPath := filepath.Join(t.TempDir(), t.Name())
 		localFile := filepath.Join(t.TempDir(), "test-file")
 		testDownloadCompressedContents := []byte("TestDownloadCompressed")
 		assert.NilError(t, os.WriteFile(localFile, testDownloadCompressedContents, 0o644))
-		assert.NilError(t, exec.Command("bzip2", localFile).Run())
+		assert.NilError(t, exec.CommandContext(ctx, "bzip2", localFile).Run())
 		localFile += ".bz2"
 		testLocalFileURL := "file://" + localFile
 

pkg/driver/external/client/client.go

@@ -25,8 +25,9 @@ func NewDriverClient(socketPath string, logger *logrus.Logger) (*DriverClient, e
 	opts := []grpc.DialOption{
 		grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(16 << 20)),
 		grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(16 << 20)),
-		grpc.WithContextDialer(func(_ context.Context, _ string) (net.Conn, error) {
-			return net.Dial("unix", socketPath)
+		grpc.WithContextDialer(func(ctx context.Context, _ string) (net.Conn, error) {
+			var dialer net.Dialer
+			return dialer.DialContext(ctx, "unix", socketPath)
 		}),
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
 	}

pkg/driver/external/server/methods.go

@@ -78,7 +78,8 @@ func (s *DriverServer) GuestAgentConn(ctx context.Context, _ *emptypb.Empty) (*e
 	if connType != "unix" {
 		proxySocketPath := filepath.Join(s.driver.Info().InstanceDir, filenames.GuestAgentSock)
 
-		listener, err := net.Listen("unix", proxySocketPath)
+		var lc net.ListenConfig
+		listener, err := lc.Listen(ctx, "unix", proxySocketPath)
 		if err != nil {
 			logrus.Errorf("Failed to create proxy socket: %v", err)
 			return nil, err