Revert "RemoteNet -> ExistingNet (#2998)" (#3073)

## Motivation

* The new name is not particularly better than the previous one that
made sense at least in contrast with local-net.
* The testnet branch and various test scripts use the old name.

## Proposal

Revert commit 909b3e7 (minus one
detail)

## Test Plan

CI

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

Author: ma2bd

.github/workflows/rust.yml

@@ -40,7 +40,7 @@ permissions:
   contents: read
 
 jobs:
-  existing-net-test:
+  remote-net-test:
     runs-on: ubuntu-latest-8-cores
     timeout-minutes: 40
 
@@ -65,9 +65,9 @@ jobs:
         cargo run --bin linera -- resource-control-policy --block 0.0000001
         cargo run --bin linera -- resource-control-policy --block 0.000000
         cargo run --bin linera -- faucet --amount 1000 --port 8079 69705f85ac4c9fef6c02b4d83426aaaf05154c645ec1c61665f8e450f0468bc0 &
-    - name: Run the existing-net tests
+    - name: Run the remote-net tests
       run: |
-        cargo test -p linera-service existing_net_grpc --features existing-net
+        cargo test -p linera-service remote_net_grpc --features remote-net
 
   execution-wasmtime-test:
     runs-on: ubuntu-latest

linera-service/Cargo.toml

@@ -54,7 +54,7 @@ kubernetes = [
     "dep:pathdiff",
     "dep:fs_extra",
 ]
-existing-net = []
+remote-net = []
 metrics = ["prometheus", "linera-base/metrics", "linera-client/metrics"]
 storage-service = ["linera-client/storage-service", "linera-storage-service"]
 

linera-service/src/cli_wrappers/mod.rs

@@ -8,9 +8,6 @@
 /// How to run docker operations
 pub mod docker;
 
-#[cfg(all(with_testing, feature = "existing-net"))]
-/// How to connect to an existing/running network.
-pub mod existing_net;
 #[cfg(feature = "kubernetes")]
 /// How to run helmfile operations
 mod helmfile;
@@ -25,6 +22,9 @@ mod kubectl;
 pub mod local_kubernetes_net;
 /// How to run Linera validators locally as native processes.
 pub mod local_net;
+#[cfg(all(with_testing, feature = "remote-net"))]
+/// How to connect to running GCP DevNet.
+pub mod remote_net;
 #[cfg(feature = "kubernetes")]
 /// Util functions for the wrappers
 mod util;

linera-service/src/cli_wrappers/existing_net.rs renamed to linera-service/src/cli_wrappers/remote_net.rs

@@ -15,12 +15,12 @@ use super::{
     Network, OnClientDrop,
 };
 
-pub struct ExistingNetTestingConfig {
+pub struct RemoteNetTestingConfig {
     faucet: Faucet,
 }
 
-impl ExistingNetTestingConfig {
-    /// Creates a new [`ExistingNetTestingConfig`] for running tests with an existing Linera
+impl RemoteNetTestingConfig {
+    /// Creates a new [`RemoteNetTestingConfig`] for running tests with an external Linera
     /// network.
     ///
     /// The `faucet_url` is used to connect to the network and obtain its configuration,
@@ -39,14 +39,14 @@ impl ExistingNetTestingConfig {
 }
 
 #[async_trait]
-impl LineraNetConfig for ExistingNetTestingConfig {
-    type Net = ExistingNet;
+impl LineraNetConfig for RemoteNetTestingConfig {
+    type Net = RemoteNet;
 
     async fn instantiate(self) -> Result<(Self::Net, ClientWrapper)> {
         let seed = 37;
-        let mut net = ExistingNet::new(Some(seed), &self.faucet)
+        let mut net = RemoteNet::new(Some(seed), &self.faucet)
             .await
-            .expect("Creating ExistingNet should not fail");
+            .expect("Creating RemoteNet should not fail");
 
         let client = net.make_client().await;
         // The tests assume we've created a genesis config with 2
@@ -78,18 +78,18 @@ impl LineraNetConfig for ExistingNetTestingConfig {
 
 /// Remote net
 #[derive(Clone)]
-pub struct ExistingNet {
+pub struct RemoteNet {
     network: Network,
     testing_prng_seed: Option<u64>,
     next_client_id: usize,
     tmp_dir: Arc<TempDir>,
 }
 
 #[async_trait]
-impl LineraNet for ExistingNet {
+impl LineraNet for RemoteNet {
     async fn ensure_is_running(&mut self) -> Result<()> {
         // Leaving this just returning for now.
-        // We would have to connect to each validator in the existing net then run
+        // We would have to connect to each validator in the remote net then run
         // ensure_connected_cluster_is_running
         Ok(())
     }
@@ -113,12 +113,12 @@ impl LineraNet for ExistingNet {
     }
 
     async fn terminate(&mut self) -> Result<()> {
-        // We're not killing the existing network :)
+        // We're not killing the remote net :)
         Ok(())
     }
 }
 
-impl ExistingNet {
+impl RemoteNet {
     async fn new(testing_prng_seed: Option<u64>, faucet: &Faucet) -> Result<Self> {
         let tmp_dir = Arc::new(tempdir()?);
         // Write json config to disk