Better convention handling. (#150)

Author: sdanyliv

Source/LinqToDB.EntityFrameworkCore/EFCoreMetadataReader.cs

@@ -9,6 +9,7 @@
 using LinqToDB.Reflection;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Diagnostics;
+using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.EntityFrameworkCore.Metadata.Internal;
 using Microsoft.EntityFrameworkCore.Query;
@@ -33,19 +34,21 @@ internal class EFCoreMetadataReader : IMetadataReader
 		readonly IModel? _model;
 		private readonly RelationalSqlTranslatingExpressionVisitorDependencies? _dependencies;
 		private readonly IRelationalTypeMappingSource? _mappingSource;
-		private readonly ConcurrentDictionary<MemberInfo, EFCoreExpressionAttribute?> _calculatedExtensions = new ConcurrentDictionary<MemberInfo, EFCoreExpressionAttribute?>();
+		private readonly IRelationalAnnotationProvider? _annotationProvider;
+		private readonly ConcurrentDictionary<MemberInfo, EFCoreExpressionAttribute?> _calculatedExtensions = new();
 		private readonly IDiagnosticsLogger<DbLoggerCategory.Query>? _logger;
 
 		public EFCoreMetadataReader(
-			IModel? model,
-			RelationalSqlTranslatingExpressionVisitorDependencies? dependencies,
-			IRelationalTypeMappingSource? mappingSource,
-			IDiagnosticsLogger<DbLoggerCategory.Query>? logger)
+			IModel? model, IInfrastructure<IServiceProvider>? accessor)
 		{
 			_model = model;
-			_dependencies = dependencies;
-			_mappingSource = mappingSource;
-			_logger = logger;
+			if (accessor != null)
+			{
+				_dependencies       = accessor.GetService<RelationalSqlTranslatingExpressionVisitorDependencies>();
+				_mappingSource      = accessor.GetService<IRelationalTypeMappingSource>();
+				_annotationProvider = accessor.GetService<IRelationalAnnotationProvider>();
+				_logger             = accessor.GetService<IDiagnosticsLogger<DbLoggerCategory.Query>>();
+			}
 		}
 
 		public T[] GetAttributes<T>(Type type, bool inherit = true) where T : Attribute
@@ -157,7 +160,17 @@ public T[] GetAttributes<T>(Type type, MemberInfo memberInfo, bool inherit = tru
 								                  .FirstOrDefault(v => CompareProperty(v.p, memberInfo))?.index ?? 0;
 						}
 
-						var isIdentity = prop.GetAnnotations()
+						var storeObjectId = GetStoreObjectIdentifier(et);
+
+						var annotations = prop.GetAnnotations();
+						if (_annotationProvider != null && storeObjectId != null)
+						{
+							var column = prop.FindColumn(storeObjectId.Value) as IColumn;
+							if (column != null)
+								annotations = annotations.Concat(_annotationProvider.For(column));
+						}
+
+						var isIdentity = annotations
 							.Any(a =>
 							{
 								if (a.Name.EndsWith(":ValueGenerationStrategy"))
@@ -178,8 +191,6 @@ public T[] GetAttributes<T>(Type type, MemberInfo memberInfo, bool inherit = tru
 								return false;
 							});
 
-						var storeObjectId = GetStoreObjectIdentifier(et);
-
 						return new T[]{(T)(Attribute) new ColumnAttribute
 						{
 							Name            = prop.GetColumnName(storeObjectId!.Value),

Source/LinqToDB.EntityFrameworkCore/ILinqToDBForEFTools.cs

@@ -1,12 +1,10 @@
-using System.Linq;
+using System;
+using System.Linq;
 using System.Linq.Expressions;
 
 using Microsoft.EntityFrameworkCore;
-using Microsoft.EntityFrameworkCore.Diagnostics;
 using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Metadata;
-using Microsoft.EntityFrameworkCore.Query;
-using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
 using Microsoft.Extensions.Logging;
 
@@ -18,7 +16,7 @@ namespace LinqToDB.EntityFrameworkCore
 	using Data;
 
 	/// <summary>
-	/// Interface for EF.Core - LINQ To DB integration bridge.
+	/// Interface for EF Core - LINQ To DB integration bridge.
 	/// </summary>
 	public interface ILinqToDBForEFTools
 	{
@@ -28,81 +26,78 @@ public interface ILinqToDBForEFTools
 		void ClearCaches();
 
 		/// <summary>
-		/// Returns LINQ To DB provider, based on provider data from EF.Core.
+		/// Returns LINQ To DB provider, based on provider data from EF Core.
 		/// </summary>
-		/// <param name="providerInfo">Provider information, extracted from EF.Core.</param>
+		/// <param name="providerInfo">Provider information, extracted from EF Core.</param>
 		/// <param name="connectionInfo">Database connection information.</param>
 		/// <returns>LINQ TO DB provider instance.</returns>
 		IDataProvider? GetDataProvider(EFProviderInfo providerInfo, EFConnectionInfo connectionInfo);
 
 		/// <summary>
-		/// Creates metadata provider for specified EF.Core data model.
+		/// Creates metadata provider for specified EF Core data model. Default implementation uses
+		/// <see cref="EFCoreMetadataReader"/> metadata provider.
 		/// </summary>
-		/// <param name="model">EF.Core data model.</param>
-		/// <param name="dependencies"></param>
-		/// <param name="mappingSource"></param>
-		/// <param name="logger"></param>
-		/// <returns>LINQ To DB metadata provider for specified EF.Core model. Can return <c>null</c>.</returns>
+		/// <param name="model">EF Core data model.</param>
+		/// <param name="accessor">EF Core service provider.</param>
+		/// <returns>LINQ To DB metadata provider for specified EF Core model.</returns>
 		IMetadataReader? CreateMetadataReader(
 			IModel? model,
-			RelationalSqlTranslatingExpressionVisitorDependencies? dependencies,
-			IRelationalTypeMappingSource? mappingSource,
-			IDiagnosticsLogger<DbLoggerCategory.Query>? logger);
+			IInfrastructure<IServiceProvider>? accessor);
 
 		/// <summary>
-		/// Creates mapping schema using provided EF.Core data model and metadata provider.
+		/// Creates mapping schema using provided EF Core data model and metadata provider.
 		/// </summary>
-		/// <param name="model">EF.Core data model.</param>
+		/// <param name="model">EF Core data model.</param>
 		/// <param name="metadataReader">Additional optional LINQ To DB database metadata provider.</param>
 		/// <param name="convertorSelector">EF Core registry for type conversion.</param>
-		/// <returns>Mapping schema for provided EF.Core model.</returns>
+		/// <returns>Mapping schema for provided EF Core model.</returns>
 		MappingSchema CreateMappingSchema(IModel model, IMetadataReader metadataReader, IValueConverterSelector convertorSelector);
 
 		/// <summary>
-		/// Returns mapping schema using provided EF.Core data model and metadata provider.
+		/// Returns mapping schema using provided EF Core data model and metadata provider.
 		/// </summary>
-		/// <param name="model">EF.Core data model.</param>
+		/// <param name="model">EF Core data model.</param>
 		/// <param name="metadataReader">Additional optional LINQ To DB database metadata provider.</param>
 		/// <param name="convertorSelector">EF Core registry for type conversion.</param>
-		/// <returns>Mapping schema for provided EF.Core model.</returns>
+		/// <returns>Mapping schema for provided EF Core model.</returns>
 		MappingSchema GetMappingSchema(IModel model, IMetadataReader? metadataReader, IValueConverterSelector? convertorSelector);
 
 		/// <summary>
-		/// Returns EF.Core <see cref="IDbContextOptions"/> for specific <see cref="DbContext"/> instance.
+		/// Returns EF Core <see cref="IDbContextOptions"/> for specific <see cref="DbContext"/> instance.
 		/// </summary>
-		/// <param name="context">EF.Core <see cref="DbContext"/> instance.</param>
+		/// <param name="context">EF Core <see cref="DbContext"/> instance.</param>
 		/// <returns><see cref="IDbContextOptions"/> instance.</returns>
 		IDbContextOptions? GetContextOptions(DbContext? context);
 
 		/// <summary>
-		/// Transforms EF.Core expression tree to LINQ To DB expression.
+		/// Transforms EF Core expression tree to LINQ To DB expression.
 		/// </summary>
-		/// <param name="expression">EF.Core expression tree.</param>
+		/// <param name="expression">EF Core expression tree.</param>
 		/// <param name="dc">LINQ To DB <see cref="IDataContext"/> instance.</param>
 		/// <param name="ctx">Optional DbContext instance.</param>
-		/// <param name="model">EF.Core data model instance.</param>
+		/// <param name="model">EF Core data model instance.</param>
 		/// <returns>Transformed expression.</returns>
 		Expression TransformExpression(Expression expression, IDataContext dc, DbContext? ctx, IModel? model);
 
 		/// <summary>
 		/// Extracts <see cref="DbContext"/> instance from <see cref="IQueryable"/> object.
 		/// </summary>
-		/// <param name="query">EF.Core query.</param>
+		/// <param name="query">EF Core query.</param>
 		/// <returns>Current <see cref="DbContext"/> instance.</returns>
 		DbContext? GetCurrentContext(IQueryable query);
 
 		/// <summary>
-		/// Extracts EF.Core connection information object from <see cref="IDbContextOptions"/>.
+		/// Extracts EF Core connection information object from <see cref="IDbContextOptions"/>.
 		/// </summary>
 		/// <param name="options"><see cref="IDbContextOptions"/> instance.</param>
-		/// <returns>EF.Core connection data.</returns>
+		/// <returns>EF Core connection data.</returns>
 		EFConnectionInfo ExtractConnectionInfo(IDbContextOptions? options);
 
 		/// <summary>
-		/// Extracts EF.Core data model instance from <see cref="IDbContextOptions"/>.
+		/// Extracts EF Core data model instance from <see cref="IDbContextOptions"/>.
 		/// </summary>
 		/// <param name="options"><see cref="IDbContextOptions"/> instance.</param>
-		/// <returns>EF.Core data model instance.</returns>
+		/// <returns>EF Core data model instance.</returns>
 		IModel? ExtractModel(IDbContextOptions? options);
 
 		/// <summary>