Clean up warnings

Author: AlfioEmanueleFresta

libwebauthn/examples/webauthn_json_hid.rs

@@ -3,22 +3,18 @@ use std::error::Error;
 use std::io::{self, Write};
 use std::time::Duration;
 
-use ctap_types::ctap2::make_credential;
 use libwebauthn::UvUpdate;
 use rand::{thread_rng, Rng};
 use text_io::read;
 use tokio::sync::broadcast::Receiver;
 use tracing_subscriber::{self, EnvFilter};
 
 use libwebauthn::ops::webauthn::{
-    GetAssertionRequest, MakeCredentialRequest, RelyingPartyId, ResidentKeyRequirement,
-    UserVerificationRequirement, WebAuthnIDL as _,
+    GetAssertionRequest, MakeCredentialRequest, RelyingPartyId, UserVerificationRequirement,
+    WebAuthnIDL as _,
 };
 use libwebauthn::pin::PinRequestReason;
-use libwebauthn::proto::ctap2::{
-    Ctap2CredentialType, Ctap2PublicKeyCredentialDescriptor, Ctap2PublicKeyCredentialRpEntity,
-    Ctap2PublicKeyCredentialUserEntity,
-};
+use libwebauthn::proto::ctap2::Ctap2PublicKeyCredentialDescriptor;
 use libwebauthn::transport::hid::list_devices;
 use libwebauthn::transport::{Channel as _, Device};
 use libwebauthn::webauthn::{Error as WebAuthnError, WebAuthn};
@@ -79,9 +75,6 @@ pub async fn main() -> Result<(), Box<dyn Error>> {
     let devices = list_devices().await.unwrap();
     println!("Devices found: {:?}", devices);
 
-    let user_id: [u8; 32] = thread_rng().gen();
-    let challenge: [u8; 32] = thread_rng().gen();
-
     for mut device in devices {
         println!("Selected HID authenticator: {}", &device);
         let mut channel = device.channel().await?;
@@ -143,6 +136,7 @@ pub async fn main() -> Result<(), Box<dyn Error>> {
         .unwrap();
         println!("WebAuthn MakeCredential response: {:?}", response);
 
+        let challenge: [u8; 32] = thread_rng().gen();
         let credential: Ctap2PublicKeyCredentialDescriptor =
             (&response.authenticator_data).try_into().unwrap();
         let get_assertion = GetAssertionRequest {

libwebauthn/src/ops/webauthn/create.rs

@@ -10,7 +10,6 @@ use crate::{
 };
 
 use serde::Deserialize;
-use serde_json::{Map as JsonMap, Value as JsonValue};
 
 /**
  * https://www.w3.org/TR/webauthn-3/#sctn-parseCreationOptionsFromJSON
@@ -34,8 +33,6 @@ fn default_user_verification() -> UserVerificationRequirement {
     UserVerificationRequirement::Preferred
 }
 
-type JsonObject = JsonMap<String, JsonValue>;
-
 #[derive(Debug, Clone, Deserialize)]
 pub struct PublicKeyCredentialCreationOptionsJSON {
     pub rp: Ctap2PublicKeyCredentialRpEntity,

libwebauthn/src/ops/webauthn/make_credential.rs

@@ -69,9 +69,9 @@ impl MakeCredentialsResponseUnsignedExtensions {
         let mut prf = None;
         if let Some(signed_extensions) = signed_extensions {
             (hmac_create_secret, prf) = if let Some(incoming_ext) = &request.extensions {
-                if let Some(hmac_create_secret) = incoming_ext.hmac_create_secret {
+                if let Some(_hmac_create_secret) = incoming_ext.hmac_create_secret {
                     (signed_extensions.hmac_secret, None)
-                } else if let Some(prf) = &incoming_ext.prf {
+                } else if let Some(_prf) = &incoming_ext.prf {
                     (
                         None,
                         Some(MakeCredentialPrfOutput {