modernize RUN commands in Containerfiles

As RUN commands on multiline is like a shell script, enable the bash
strict mode. So we can remove all the `&&` at the begin of lines.

When buildah (podman builder) recent release will be published in common
distributions (at least Debian stable), we will be able to use the
"heredoc" syntax to avoid all the `; \` at end of lines.

Author: Trim

Container.md

@@ -16,6 +16,7 @@ If you use Podman, you can either use the same Docker compose plugin or the
 [podman-compose](https://github.com/containers/podman-compose/)
 utility. The podman cli itself provide a wrapper of one of these two tools through the
 [`podman compose` command](https://docs.podman.io/en/latest/markdown/podman-compose.1.html).
+Thus you need to use the `podman compose up` command to start the system.
 
 At this point, the documentation will give you `docker compose` commands, but you should be able
 to use `podman compose` without any issue.

deployment/database/docker-entrypoint-initdb.d/001-create-database-test.sh

@@ -1,6 +1,7 @@
 #/usr/bin/env sh
 
 set -euo pipefail
+IFS=$'\n\t'
 
 mysql -uroot -hlocalhost -p"${MYSQL_ROOT_PASSWORD}" <<EOSQL
   CREATE USER IF NOT EXISTS '${MYSQL_TEST_USER}'@'%' IDENTIFIED BY '${MYSQL_TEST_PASSWORD}';

deployment/linuxfr-img/Containerfile

@@ -10,10 +10,13 @@ LABEL org.opencontainers.image.authors="Adrien Dorsaz <[email protected]>"
 
 ARG UID=1200
 
-RUN apt-get update \
-  && apt-get install -y --no-install-recommends \
-    golang git ca-certificates \
-  && apt-get clean
+RUN \
+  set -eux; \
+  IFS=$'\n\t'; \
+  apt-get update; \
+  apt-get install -y --no-install-recommends \
+    golang git ca-certificates; \
+  apt-get clean;
 
 USER ${UID}
 ENV GOPATH=/linuxfr-img

deployment/linuxfr.org/Containerfile

@@ -11,16 +11,19 @@ LABEL org.opencontainers.image.authors="Adrien Dorsaz <[email protected]>"
 ARG UID=1200
 
 # Install system dependencies
-RUN apt-get update \
-  && apt-get install -y --no-install-recommends --allow-downgrades \
+RUN \
+  set -eux; \
+  IFS=$'\n\t'; \
+  apt-get update; \
+  apt-get install -y --no-install-recommends --allow-downgrades \
     mariadb-client libmariadb++-dev git \
     build-essential openssl libreadline-dev curl libcurl4-openssl-dev zlib1g \
     zlib1g-dev libssl-dev libxml2-dev libxslt-dev autoconf libgmp-dev libyaml-dev \
     ncurses-dev bison automake libtool imagemagick libc6-dev hunspell \
     hunspell-fr-comprehensive ruby ruby-dev ruby-rack \
-    nodejs npm \
-  && gem install bundler -v 2.4.20 \
-  && apt-get clean
+    nodejs npm; \
+  gem install bundler -v 2.4.20; \
+  apt-get clean;
 
 USER ${UID}
 ENV HOME=/linuxfr.org
@@ -29,9 +32,12 @@ WORKDIR /linuxfr.org
 # Install external dependencies
 COPY --chown=${UID}:0 --chmod=770 Gemfile* ./
 
-RUN bundle config set path 'vendor/bundle' \
-  && bundle config set deployment 'true' \
-  && bundle install
+RUN \
+  set -eux; \
+  IFS=$'\n\t'; \
+  bundle config set path 'vendor/bundle'; \
+  bundle config set deployment 'true'; \
+  bundle install;
 
 # Configure the application
 COPY --chown=${UID}:0 --chmod=770 deployment/linuxfr.org/database.yml config/database.yml