Skip to content

Commit 305d477

Browse files
Bot Updating Documentation
1 parent 2cd519f commit 305d477

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

docs/images/docker-github-desktop.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ By default, this container has no authentication. The optional `CUSTOM_USER` and
6161

6262
The web interface includes a terminal with passwordless `sudo` access. Any user with access to the GUI can gain root control within the container, install arbitrary software, and probe your local network.
6363

64+
While not generally recommended, certain legacy environments specifically those with older hardware or outdated Linux distributions may require the deactivation of the standard seccomp profile to get containerized desktop software to run. This can be achieved by utilizing the `--security-opt seccomp=unconfined` parameter. It is critical to use this option only when absolutely necessary as it disables a key security layer of Docker, elevating the potential for container escape vulnerabilities.
65+
6466
### Options in all Selkies-based GUI containers
6567

6668
This container is based on [Docker Baseimage Selkies](https://github.com/linuxserver/docker-baseimage-selkies), which provides the following environment variables and run configurations to customize its functionality.
@@ -207,8 +209,6 @@ services:
207209
container_name: github-desktop
208210
cap_add:
209211
- IPC_LOCK
210-
security_opt:
211-
- seccomp:unconfined #optional
212212
environment:
213213
- PUID=1000
214214
- PGID=1000
@@ -228,7 +228,6 @@ services:
228228
docker run -d \
229229
--name=github-desktop \
230230
--cap-add=IPC_LOCK \
231-
--security-opt seccomp=unconfined `#optional` \
232231
-e PUID=1000 \
233232
-e PGID=1000 \
234233
-e TZ=Etc/UTC \
@@ -270,7 +269,6 @@ Containers are configured using parameters passed at runtime (such as those abov
270269
| Parameter | Function |
271270
| :-----: | --- |
272271
| `--shm-size=` | This is needed for electron applications to function properly. |
273-
| `--security-opt seccomp=unconfined` | For Docker Engine only, many modern gui apps need this to function on older hosts as syscalls are unknown to Docker. Github Desktop runs in no-sandbox mode without it. |
274272
| `--cap-add=IPC_LOCK` | Required for keyring functionality. |
275273

276274
### Portainer notice
@@ -508,13 +506,14 @@ To help with development, we generate this dependency graph.
508506
svc-xsettingsd -> legacy-services
509507
}
510508
Base Images: {
511-
"baseimage-selkies:debianbookworm" <- "baseimage-debian:bookworm"
509+
"baseimage-selkies:debiantrixie" <- "baseimage-debian:trixie"
512510
}
513511
"github-desktop:latest" <- Base Images
514512
```
515513

516514
## Versions
517515

516+
* **22.09.25:** - Rebase to Debian Trixie.
518517
* **12.07.25:** - Rebase to Selkies, HTTPS IS NOW REQUIRED.
519518
* **10.02.24:** - Update Readme with new env vars and ingest proper PWA icon.
520519
* **03.08.23:** - Rebase to Bookworm and multi arch.

0 commit comments

Comments
 (0)