Skip to content

[FIRRTL] LowerSigs: Add enum support #8731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

[FIRRTL] LowerSigs: Add enum support #8731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Dialect/FIRRTL/Transforms/LowerSignatures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ computeLoweringImpl(FModuleLike mod, PortConversion &newPorts, Convention conv,
}
return success();
})
.Case<FEnumType>([&](FEnumType fenum) { return failure(); })
.Default([&](FIRRTLType type) {
// Properties and other types wind up here.
newPorts.push_back(
Expand Down
9 changes: 9 additions & 0 deletions test/Dialect/FIRRTL/lower-types.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,15 @@ firrtl.circuit "TopLevel" {
firrtl.connect %out, %in: !firrtl.vector<bundle<a : uint<1>, b flip: uint<1>>, 2>, !firrtl.vector<bundle<a : uint<1>, b flip: uint<1>>, 2>
}

// Test enum lowering. Currently leaves enumerations untouched.
// CHECK-LABEL: @LowerEnums
// CHECK: %a: !firrtl.enum<a: uint<1>>
// CHECK: %b: !firrtl.enum<a: uint<1>>
firrtl.module private @LowerEnums(in %a: !firrtl.enum<a: uint<1>>, out %b: !firrtl.enum<a: uint<1>>) {
// CHECK: firrtl.matchingconnect %b, %a : !firrtl.enum<a: uint<1>>
firrtl.matchingconnect %b, %a : !firrtl.enum<a: uint<1>>
}

// COMMON-LABEL: firrtl.extmodule @ExternalModule(in source_valid: !firrtl.uint<1>, out source_ready: !firrtl.uint<1>, in source_data: !firrtl.uint<64>)
firrtl.extmodule @ExternalModule(in source: !firrtl.bundle<valid: uint<1>, ready flip: uint<1>, data: uint<64>>)
firrtl.module private @Test() {
Expand Down