Skip to content

Conversation

@ChristianKuehnel
Copy link
Contributor

@ChristianKuehnel ChristianKuehnel commented Jan 20, 2021

The low-hanging fruit for automatic checks is probably getting tox executed on Github Actions.

I was able to run flake8 , mypy and docs successfully.

However I failed with the test suite. We probably need to set up some more things in the environment...

The output of the Github Actions is visible here: https://github.com/ChristianKuehnel/llvm-lnt/actions

@cmatthew
Copy link
Contributor

We do have CI for that already:

http://green.lab.llvm.org/green/job/LNT_Tests/

@ChristianKuehnel
Copy link
Contributor Author

Oh sorry I did not see these. I just saw that you have open pull requests and they are not checked via any CI. So I thought it would be nice to have automatic CI coverage for these. Setting up Github Actions is quite easy to do, so I just gave it a shot.

Looking closer the open Pull Requests are also just automatic PRs for security fixes, so no user interaction there I guess...

But you could of course also configure your existing Jenkins server to 1) annotate the commits on GitHub with the build results and 2) to also check pull requests.

@ldionne
Copy link
Member

ldionne commented Oct 1, 2025

This job on Green dragon has been spun down AFAICT. I think there's a lot of benefit to setting up automated testing for PRs.

@cmatthew What do you think about landing this now?

@ldionne
Copy link
Member

ldionne commented Oct 3, 2025

I'll go ahead and try merging this to see what works and what doesn't. I think there's a lot of value in having automated testing immediately in Github PRs and the free tier machines should be way sufficient for our needs.

@ldionne ldionne merged commit de742ec into llvm:main Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants