Address minor feedback part 2

Author: eZWALT

clang/include/clang/AST/OpenMPClause.h

@@ -1197,12 +1197,16 @@ class OMPLoopRangeClause final
   void setFirstLoc(SourceLocation Loc) { FirstLoc = Loc; }
   void setCountLoc(SourceLocation Loc) { CountLoc = Loc; }
 
-  /// Get looprange arguments: first and count
+  /// Get looprange 'first' expression
   Expr *getFirst() const { return getArgs()[0]; }
+
+  /// Get looprange 'count' expression
   Expr *getCount() const { return getArgs()[1]; }
 
-  /// Set looprange arguments: first and count
+  /// Set looprange 'first' expression
   void setFirst(Expr *E) { getArgs()[0] = E; }
+
+  /// Set looprange 'count' expression
   void setCount(Expr *E) { getArgs()[1] = E; }
 
   MutableArrayRef<Expr *> getArgs() {

clang/include/clang/AST/StmtOpenMP.h

@@ -976,6 +976,7 @@ class OMPLoopTransformationDirective : public OMPLoopBasedDirective {
 
   /// Set the number of loops generated by this loop transformation.
   void setNumGeneratedLoops(unsigned Num) { NumGeneratedLoops = Num; }
+
   /// Set the number of top level canonical loop nests generated by this loop
   /// transformation
   void setNumGeneratedLoopNests(unsigned Num) { NumGeneratedLoopNests = Num; }

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -11612,16 +11612,16 @@ def note_omp_implicit_dsa : Note<
   "implicitly determined as %0">;
 def err_omp_loop_var_dsa : Error<
   "loop iteration variable in the associated loop of 'omp %1' directive may not be %0, predetermined as %2">;
-def err_omp_not_canonical_loop : Error <
+def err_omp_not_canonical_loop : Error<
   "loop after '#pragma omp %0' is not in canonical form">;
-def err_omp_not_a_loop_sequence : Error < 
+def err_omp_not_a_loop_sequence : Error< 
   "statement after '#pragma omp %0' must be a loop sequence containing canonical loops or loop-generating constructs">;
-def err_omp_empty_loop_sequence : Error <
+def err_omp_empty_loop_sequence : Error<
   "loop sequence after '#pragma omp %0' must contain at least 1 canonical loop or loop-generating construct">;
-def err_omp_invalid_looprange : Error <
+def err_omp_invalid_looprange : Error<
   "loop range in '#pragma omp %0' exceeds the number of available loops: "
   "range end '%1' is greater than the total number of loops '%2'">;
-def warn_omp_redundant_fusion : Warning <
+def warn_omp_redundant_fusion : Warning<
   "loop range in '#pragma omp %0' contains only a single loop, resulting in redundant fusion">,
   InGroup<OpenMPClauses>;
 def err_omp_not_for : Error<

clang/lib/Sema/SemaOpenMP.cpp

@@ -22,7 +22,6 @@
 #include "clang/AST/DeclOpenMP.h"
 #include "clang/AST/DynamicRecursiveASTVisitor.h"
 #include "clang/AST/OpenMPClause.h"
-#include "clang/AST/RecursiveASTVisitor.h"
 #include "clang/AST/StmtCXX.h"
 #include "clang/AST/StmtOpenMP.h"
 #include "clang/AST/StmtVisitor.h"
@@ -48,7 +47,6 @@
 #include "llvm/Frontend/OpenMP/OMPConstants.h"
 #include "llvm/IR/Assumptions.h"
 #include <optional>
-#include <queue>
 
 using namespace clang;
 using namespace llvm::omp;
@@ -14201,7 +14199,6 @@ template <typename T, typename F> static bool tryHandleAs(T *t, F &&) {
   return false;
 }
 
-///
 /// Tries to recursively cast `t` to one of the given types and invokes `f` if
 /// successful.
 ///
@@ -14274,7 +14271,7 @@ bool SemaOpenMP::checkTransformableLoopNest(
 
 /// Counts the total number of nested loops, including the outermost loop (the
 /// original loop). PRECONDITION of this visitor is that it must be invoked from
-/// the original loop to be analyzed. The traversal is stop for Decl's and
+/// the original loop to be analyzed. The traversal stops for Decl's and
 /// Expr's given that they may contain inner loops that must not be counted.
 ///
 /// Example AST structure for the code:
@@ -15945,7 +15942,7 @@ StmtResult SemaOpenMP::ActOnOpenMPFuseDirective(ArrayRef<OMPClause *> Clauses,
 
   // Select the type with the largest bit width among all induction variables
   QualType IVType = LoopHelpers[FirstVal - 1].IterationVarRef->getType();
-  for (unsigned int I = FirstVal; I < LastVal; ++I) {
+  for (unsigned I = FirstVal; I < LastVal; ++I) {
     QualType CurrentIVType = LoopHelpers[I].IterationVarRef->getType();
     if (Context.getTypeSize(CurrentIVType) > Context.getTypeSize(IVType)) {
       IVType = CurrentIVType;
@@ -16054,9 +16051,8 @@ StmtResult SemaOpenMP::ActOnOpenMPFuseDirective(ArrayRef<OMPClause *> Clauses,
     auto [IVVD, IVDStmt] =
         CreateHelperVarAndStmt(LoopHelpers[I].IterationVarRef, "iv", J);
 
-    if (!LBVD || !STVD || !NIVD || !IVVD)
-      assert(LBVD && STVD && NIVD && IVVD &&
-             "OpenMP Fuse Helper variables creation failed");
+    assert(LBVD && STVD && NIVD && IVVD &&
+           "OpenMP Fuse Helper variables creation failed");
 
     UBVarDecls.push_back(UBVD);
     LBVarDecls.push_back(LBVD);
@@ -16097,11 +16093,10 @@ StmtResult SemaOpenMP::ActOnOpenMPFuseDirective(ArrayRef<OMPClause *> Clauses,
   //      original.indexk = ivk
   //      body(k);  Expr *InitVal = IntegerLiteral::Create(Context,
   //      llvm::APInt(IVWidth, 0),
-
   //    }
 
   // 1. Create the initialized fuse index
-  const std::string IndexName = Twine(".omp.fuse.index").str();
+  StringRef IndexName = ".omp.fuse.index";
   Expr *InitVal = IntegerLiteral::Create(Context, llvm::APInt(IVBitWidth, 0),
                                          IVType, SourceLocation());
   VarDecl *IndexDecl =