Skip to content

Commit 0b68019

Browse files
committed
fixup! Add same lookup target env logic in GPUModuleConversion
remove unnecessary namespace qualifiers
1 parent 40b6f07 commit 0b68019

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,7 @@ LogicalResult GPUModuleConversion::matchAndRewrite(
386386
spirv::getTargetEnvAttrName()))
387387
spvModule->setAttr(spirv::getTargetEnvAttrName(), attr);
388388
for (auto targetAttr : moduleOp.getTargetsAttr())
389-
if (auto spirvTargetEnvAttr =
390-
llvm::dyn_cast<spirv::TargetEnvAttr>(targetAttr))
389+
if (auto spirvTargetEnvAttr = dyn_cast<spirv::TargetEnvAttr>(targetAttr))
391390
spvModule->setAttr(spirv::getTargetEnvAttrName(), spirvTargetEnvAttr);
392391

393392
rewriter.eraseOp(moduleOp);

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRVPass.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ struct GPUToSPIRVPass final : impl::ConvertGPUToSPIRVBase<GPUToSPIRVPass> {
5656
spirv::TargetEnvAttr
5757
GPUToSPIRVPass::lookupTargetEnvInTargets(gpu::GPUModuleOp moduleOp) {
5858
for (auto &targetAttr : moduleOp.getTargetsAttr())
59-
if (auto spirvTargetEnvAttr =
60-
llvm::dyn_cast<spirv::TargetEnvAttr>(targetAttr))
59+
if (auto spirvTargetEnvAttr = dyn_cast<spirv::TargetEnvAttr>(targetAttr))
6160
return spirvTargetEnvAttr;
6261

6362
return {};
@@ -105,7 +104,7 @@ void GPUToSPIRVPass::runOnOperation() {
105104
// TargetEnv attributes.
106105
for (Operation *gpuModule : gpuModules) {
107106
spirv::TargetEnvAttr targetAttr =
108-
lookupTargetEnvOrDefault(llvm::cast<gpu::GPUModuleOp>(gpuModule));
107+
lookupTargetEnvOrDefault(cast<gpu::GPUModuleOp>(gpuModule));
109108

110109
// Map MemRef memory space to SPIR-V storage class first if requested.
111110
if (mapMemorySpace) {

0 commit comments

Comments
 (0)