Skip to content

Commit 28ce00f

Browse files
committed
Addressing Review Comments
1 parent cdbe34c commit 28ce00f

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5136,13 +5136,13 @@ static MachineBasicBlock *lowerWaveReduce(MachineInstr &MI,
51365136
if (isSGPR) {
51375137
switch (Opc) {
51385138
case AMDGPU::S_MIN_U32:
5139-
case AMDGPU::V_CMP_LT_U64_e64: /*umin*/
5139+
case AMDGPU::V_CMP_LT_U64_e64: // umin
51405140
case AMDGPU::S_MIN_I32:
5141-
case AMDGPU::V_CMP_LT_I64_e64: /*min*/
5141+
case AMDGPU::V_CMP_LT_I64_e64: // min
51425142
case AMDGPU::S_MAX_U32:
5143-
case AMDGPU::V_CMP_GT_U64_e64: /*umax*/
5143+
case AMDGPU::V_CMP_GT_U64_e64: // umax
51445144
case AMDGPU::S_MAX_I32:
5145-
case AMDGPU::V_CMP_GT_I64_e64: /*max*/
5145+
case AMDGPU::V_CMP_GT_I64_e64: // max
51465146
case AMDGPU::S_AND_B32:
51475147
case AMDGPU::S_OR_B32: {
51485148
// Idempotent operations.
@@ -5341,9 +5341,7 @@ static MachineBasicBlock *lowerWaveReduce(MachineInstr &MI,
53415341
Register LaneMaskReg = MRI.createVirtualRegister(WaveMaskRegClass);
53425342
Register ComparisonResultReg =
53435343
MRI.createVirtualRegister(WaveMaskRegClass);
5344-
const TargetRegisterClass *VregClass =
5345-
ST.needsAlignedVGPRs() ? &AMDGPU::VReg_64_Align2RegClass
5346-
: &AMDGPU::VReg_64RegClass;
5344+
const TargetRegisterClass *VregClass = TRI->getVGPR64Class();
53475345
const TargetRegisterClass *VSubRegClass =
53485346
TRI->getSubRegisterClass(VregClass, AMDGPU::sub0);
53495347
Register AccumulatorVReg = MRI.createVirtualRegister(VregClass);

0 commit comments

Comments
 (0)