Skip to content

Commit 47dc4f1

Browse files
committed
implement feedback
1 parent 8d2b926 commit 47dc4f1

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3038,16 +3038,10 @@ bool IRTranslator::translateCallBr(const User &U,
30383038
if (!translateInlineAsm(I, MIRBuilder))
30393039
return false;
30403040
} else if (I.getIntrinsicID() != Intrinsic::not_intrinsic) {
3041-
switch (I.getIntrinsicID()) {
3042-
default:
3043-
report_fatal_error("Unsupported intrinsic for callbr");
3044-
case Intrinsic::amdgcn_kill:
3045-
if (!translateTargetIntrinsic(I, Intrinsic::amdgcn_kill, MIRBuilder))
3046-
return false;
3047-
break;
3048-
}
3041+
if (!translateTargetIntrinsic(I, I.getIntrinsicID(), MIRBuilder))
3042+
return false;
30493043
} else {
3050-
report_fatal_error("Only know how to handle inlineasm/intrinsic callbr");
3044+
return false;
30513045
}
30523046

30533047
// Retrieve successors.

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3401,15 +3401,9 @@ void SelectionDAGBuilder::visitCallBr(const CallBrInst &I) {
34013401
if (I.isInlineAsm()) {
34023402
visitInlineAsm(I);
34033403
} else if (I.getIntrinsicID() != Intrinsic::not_intrinsic) {
3404-
switch (I.getIntrinsicID()) {
3405-
default:
3406-
report_fatal_error("Unsupported intrinsic for callbr");
3407-
case Intrinsic::amdgcn_kill:
3408-
visitCallBrIntrinsic(I);
3409-
break;
3410-
}
3404+
visitCallBrIntrinsic(I);
34113405
} else {
3412-
report_fatal_error("Only know how to handle inlineasm/intrinsic callbr");
3406+
report_fatal_error("only know how to handle inlineasm/intrinsic callbr");
34133407
}
34143408
CopyToExportRegsIfNeeded(&I);
34153409

0 commit comments

Comments
 (0)