Skip to content

Commit 66c1a8e

Browse files
ldionneldionne
committed
[libc++] Remove mentions of Clang 18 in the test suite
Clang 19 has been the oldest supported version of Clang since the LLVM 20 release, but we had not cleaned up the test suite yet.
1 parent 2435ea6 commit 66c1a8e

File tree

19 files changed

+8
-60
lines changed

19 files changed

+8
-60
lines changed

‎libcxx/test/libcxx/fuzzing/random.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// This test fails because Clang no longer enables -fdelayed-template-parsing
1010
// by default on Windows with C++20 (#69431).
11-
// XFAIL: msvc && (clang-18 || clang-19 || clang-20 || clang-21)
11+
// XFAIL: msvc && (clang-19 || clang-20 || clang-21)
1212

1313
// UNSUPPORTED: c++03, c++11
1414

‎libcxx/test/libcxx/memory/shared_ptr_array.pass.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
// UNSUPPORTED: c++03, c++11, c++14, c++17
1111

1212
// These compiler versions and platforms don't enable sized deallocation by default.
13-
// ADDITIONAL_COMPILE_FLAGS(clang-17): -fsized-deallocation
14-
// ADDITIONAL_COMPILE_FLAGS(clang-18): -fsized-deallocation
1513
// ADDITIONAL_COMPILE_FLAGS(apple-clang-16): -fsized-deallocation
1614
// ADDITIONAL_COMPILE_FLAGS(target=x86_64-w64-windows-gnu): -fsized-deallocation
1715
// ADDITIONAL_COMPILE_FLAGS(target=i686-w64-windows-gnu): -fsized-deallocation

‎libcxx/test/libcxx/utilities/expected/expected.expected/transform_error.mandates.verify.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// Clang-18 fixed some spurious clang diagnostics. Once clang-18 is the
10-
// minimum required version these obsolete tests can be removed.
11-
// TODO(LLVM-20) remove spurious clang diagnostic tests.
12-
139
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
1410

1511
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
@@ -59,12 +55,10 @@ void test() {
5955
{
6056
std::expected<int, int> e;
6157
e.transform_error(return_unexpected<int&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
62-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
6358
// expected-error-re@*:* {{static assertion failed {{.*}}[expected.object.general] A program that instantiates the definition of template expected<T, E> for {{.*}} is ill-formed.}}
6459
// expected-error-re@*:* 0-1 {{union member {{.*}} has reference type {{.*}}}}
6560

6661
e.transform_error(return_no_object<int&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
67-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
6862
// expected-error-re@*:* {{static assertion failed {{.*}}[expected.object.general] A program that instantiates the definition of template expected<T, E> for {{.*}} is ill-formed.}}
6963
// expected-warning-re@*:* 0-1 {{union member {{.*}} has reference type {{.*}}, which is a Microsoft extension}}
7064
}
@@ -73,27 +67,21 @@ void test() {
7367
{
7468
const std::expected<int, int> e;
7569
e.transform_error(return_unexpected<const int &>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
76-
// expected-error-re@*:* 0-2 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
7770
e.transform_error(return_no_object<const int &>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
78-
// expected-error-re@*:* 0-2 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
7971
}
8072

8173
// Test && overload
8274
{
8375
std::expected<int, int> e;
8476
std::move(e).transform_error(return_unexpected<int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
85-
// expected-error-re@*:* 0-2 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
8677
std::move(e).transform_error(return_no_object<int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
87-
// expected-error-re@*:* 0-2 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
8878
}
8979

9080
// Test const&& overload
9181
{
9282
const std::expected<int, int> e;
9383
std::move(e).transform_error(return_unexpected<const int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
94-
// expected-error-re@*:* 0-2 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
9584
std::move(e).transform_error(return_no_object<const int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
96-
// expected-error-re@*:* 0-2 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
9785
}
9886
}
9987
// clang-format on

‎libcxx/test/libcxx/utilities/expected/expected.void/transform_error.mandates.verify.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// Clang-18 fixed some spurious clang diagnostics. Once clang-18 is the
10-
// minumum required version these obsolete tests can be removed.
11-
// TODO(LLVM-20) remove spurious clang diagnostic tests.
12-
139
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
1410

1511
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
@@ -60,13 +56,11 @@ void test() {
6056
{
6157
std::expected<void, int> e;
6258
e.transform_error(return_unexpected<int&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
63-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
6459
// expected-error-re@*:* {{static assertion failed {{.*}}A program that instantiates expected<T, E> with a E that is not a valid argument for unexpected<E> is ill-formed}}
6560
// expected-error-re@*:* 0-1 {{call to deleted constructor of {{.*}}}}
6661
// expected-error-re@*:* 0-1 {{union member {{.*}} has reference type {{.*}}}}
6762

6863
e.transform_error(return_no_object<int&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
69-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
7064
// expected-error-re@*:* {{static assertion failed {{.*}}A program that instantiates expected<T, E> with a E that is not a valid argument for unexpected<E> is ill-formed}}
7165
// expected-warning-re@*:* 0-1 {{union member {{.*}} has reference type {{.*}}, which is a Microsoft extension}}
7266
}
@@ -75,28 +69,22 @@ void test() {
7569
{
7670
const std::expected<void, int> e;
7771
e.transform_error(return_unexpected<const int &>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
78-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
7972
e.transform_error(return_no_object<const int &>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
80-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
8173
// expected-error-re@*:* 0-1 {{call to deleted constructor of {{.*}}}}
8274
}
8375

8476
// Test && overload
8577
{
8678
std::expected<void, int> e;
8779
std::move(e).transform_error(return_unexpected<int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
88-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
8980
std::move(e).transform_error(return_no_object<int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
90-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
9181
}
9282

9383
// Test const&& overload
9484
{
9585
const std::expected<void, int> e;
9686
std::move(e).transform_error(return_unexpected<const int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
97-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
9887
std::move(e).transform_error(return_no_object<const int&&>); // expected-error-re@*:* {{static assertion failed {{.*}}The result of {{.*}} must be a valid template argument for unexpected}}
99-
// expected-error-re@*:* 0-1 {{{{(excess elements in struct initializer|no matching constructor for initialization of)}}{{.*}}}}
10088
}
10189
}
10290
// clang-format on

‎libcxx/test/std/atomics/atomics.types.generic/atomics.types.float/fetch_add.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
// UNSUPPORTED: c++03, c++11, c++14, c++17
99
// XFAIL: !has-64-bit-atomics
1010

11-
// Older versions of clang have a bug with atomic builtins affecting double and long double.
12-
// Fixed by 5fdd0948.
13-
// XFAIL: target=powerpc-ibm-{{.*}} && clang-18
14-
1511
// https://github.com/llvm/llvm-project/issues/72893
1612
// XFAIL: target={{x86_64-.*}} && tsan
1713

‎libcxx/test/std/atomics/atomics.types.generic/atomics.types.float/fetch_sub.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
// UNSUPPORTED: c++03, c++11, c++14, c++17
99
// XFAIL: !has-64-bit-atomics
1010

11-
// Older versions of clang have a bug with atomic builtins affecting double and long double.
12-
// Fixed by 5fdd0948.
13-
// XFAIL: target=powerpc-ibm-{{.*}} && clang-18
14-
1511
// https://github.com/llvm/llvm-project/issues/72893
1612
// XFAIL: target={{x86_64-.*}} && tsan
1713

‎libcxx/test/std/atomics/atomics.types.generic/atomics.types.float/operator.minus_equals.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
// UNSUPPORTED: c++03, c++11, c++14, c++17
99
// XFAIL: !has-64-bit-atomics
1010

11-
// Older versions of clang have a bug with atomic builtins affecting double and long double.
12-
// Fixed by 5fdd0948.
13-
// XFAIL: target=powerpc-ibm-{{.*}} && clang-18
14-
1511
// floating-point-type operator-=(floating-point-type) volatile noexcept;
1612
// floating-point-type operator-=(floating-point-type) noexcept;
1713

‎libcxx/test/std/atomics/atomics.types.generic/atomics.types.float/operator.plus_equals.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
// UNSUPPORTED: c++03, c++11, c++14, c++17
99
// XFAIL: !has-64-bit-atomics
1010

11-
// Older versions of clang have a bug with atomic builtins affecting double and long double.
12-
// Fixed by 5fdd0948.
13-
// XFAIL: target=powerpc-ibm-{{.*}} && clang-18
14-
1511
// floating-point-type operator+=(floating-point-type) volatile noexcept;
1612
// floating-point-type operator+=(floating-point-type) noexcept;
1713

‎libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// This test fails because Clang no longer enables -fdelayed-template-parsing
1010
// by default on Windows with C++20 (#69431).
11-
// XFAIL: msvc && (clang-18 || clang-19 || clang-20 || clang-21)
11+
// XFAIL: msvc && (clang-19 || clang-20 || clang-21)
1212

1313
// <math.h>
1414

‎libcxx/test/std/experimental/simd/simd.class/simd_copy.pass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88

99
// UNSUPPORTED: c++03, c++11, c++14
1010

11-
// Older versions of clang may encounter a backend error (see 0295c2ad):
12-
// Pass-by-value arguments with alignment greater than register width are not supported.
13-
// XFAIL: target=powerpc{{.*}}-ibm-{{.*}} && clang-18
14-
1511
// <experimental/simd>
1612
//
1713
// [simd.class]

0 commit comments

Comments
 (0)