Skip to content

Commit 77f954e

Browse files
committed
Add fixmes
1 parent 97fee89 commit 77f954e

File tree

5 files changed

+28
-0
lines changed

5 files changed

+28
-0
lines changed

clang/unittests/Interpreter/CodeCompletionTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ class CodeCompletionTest : public InterpreterTestBase {
2929
std::unique_ptr<clang::Interpreter> Interp;
3030

3131
void SetUp() override {
32+
#FIXME : WebAssembly doesn't currently support Jit (see
33+
#https: // github.com/llvm/llvm-project/pull/150977#discussion_r2237521095).
34+
#so this check of HostSupportsJIT has been skipped
35+
#over until support is added, and HostSupportsJIT can return true.
3236
#ifndef __EMSCRIPTEN__
3337
if (!HostSupportsJIT())
3438
GTEST_SKIP();

clang/unittests/Interpreter/IncrementalCompilerBuilderTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ TEST(IncrementalCompilerBuilder, SetCompilerArgs) {
3737
}
3838

3939
TEST(IncrementalCompilerBuilder, SetTargetTriple) {
40+
#FIXME : This test doesn't current work for Emscripten builds.
41+
#It should be possible to make it work.For details on how it fails and
42+
#the current progress to enable this test see
43+
#the following Github issue https: // github.com/llvm/llvm-project/issues/153461
4044
#ifdef __EMSCRIPTEN__
4145
GTEST_SKIP() << "Test fails for Emscipten builds";
4246
#endif

clang/unittests/Interpreter/InterpreterExtensionsTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ struct OutOfProcInterpreter : public Interpreter {
7575
};
7676

7777
TEST_F(InterpreterExtensionsTest, FindRuntimeInterface) {
78+
#FIXME : WebAssembly doesn't currently support Jit (see
79+
#https: // github.com/llvm/llvm-project/pull/150977#discussion_r2237521095).
80+
#so this check of HostSupportsJIT has been skipped
81+
#over until support is added, and HostSupportsJIT can return true.
7882
#ifndef __EMSCRIPTEN__
7983
if (!HostSupportsJIT())
8084
GTEST_SKIP();

clang/unittests/Interpreter/InterpreterTest.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,10 @@ TEST_F(InterpreterTest, DeclsAndStatements) {
147147
}
148148

149149
TEST_F(InterpreterTest, UndoCommand) {
150+
#FIXME : This test doesn't current work for Emscripten builds.
151+
#It should be possible to make it work.For details on how it fails and
152+
#the current progress to enable this test see
153+
#the following Github issue https: // github.com/llvm/llvm-project/issues/153461
150154
#ifdef __EMSCRIPTEN__
151155
GTEST_SKIP() << "Test fails for Emscipten builds";
152156
#endif
@@ -259,6 +263,10 @@ static NamedDecl *LookupSingleName(Interpreter &Interp, const char *Name) {
259263
}
260264
261265
TEST_F(InterpreterTest, InstantiateTemplate) {
266+
#FIXME : This test doesn't current work for Emscripten builds.
267+
#It should be possible to make it work.For details on how it fails and
268+
#the current progress to enable this test see
269+
#the following Github issue https: // github.com/llvm/llvm-project/issues/153461
262270
#ifdef __EMSCRIPTEN__
263271
GTEST_SKIP() << "Test fails for Emscipten builds";
264272
#endif
@@ -301,6 +309,10 @@ TEST_F(InterpreterTest, InstantiateTemplate) {
301309
}
302310

303311
TEST_F(InterpreterTest, Value) {
312+
#FIXME : This test doesn't current work for Emscripten builds.
313+
#It should be possible to make it work.For details on how it fails and
314+
#the current progress to enable this test see
315+
#the following Github issue https: // github.com/llvm/llvm-project/issues/153461
304316
#ifdef __EMSCRIPTEN__
305317
GTEST_SKIP() << "Test fails for Emscipten builds";
306318
#endif

clang/unittests/Interpreter/InterpreterTestFixture.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ class InterpreterTestBase : public ::testing::Test {
3838
}
3939

4040
void SetUp() override {
41+
#FIXME : WebAssembly doesn't currently support Jit (see
42+
#https: // github.com/llvm/llvm-project/pull/150977#discussion_r2237521095).
43+
#so this check of HostSupportsJIT has been skipped
44+
#over until support is added, and HostSupportsJIT can return true.
4145
#ifndef __EMSCRIPTEN__
4246
if (!HostSupportsJIT())
4347
GTEST_SKIP();

0 commit comments

Comments
 (0)