Skip to content

Commit 825f11b

Browse files
committed
fix upon review
1 parent d16448a commit 825f11b

File tree

9 files changed

+397
-58
lines changed

9 files changed

+397
-58
lines changed

mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class Linalg_RelayoutOp<string mnemonic, list<Trait> traits = []> :
3636
DestinationStyleOpInterface, LinalgRelayoutOpInterface,
3737
ConditionallySpeculatable, DeclareOpInterfaceMethods<MemoryEffectsOpInterface>,
3838
DeclareOpInterfaceMethods<ReifyRankedShapedTypeOpInterface>,
39-
TypesMatchWith<"result type matches type of dest",
39+
OptionalTypesMatchWith<"result type matches type of dest",
4040
"dest", "result",
4141
"$_self">])> {
4242

@@ -175,16 +175,9 @@ def Linalg_PackOp : Linalg_RelayoutOp<"pack", [
175175
DenseI64ArrayAttr:$inner_dims_pos,
176176
Variadic<Index>:$inner_tiles,
177177
DenseI64ArrayAttr:$static_inner_tiles);
178-
let results = (outs AnyShaped:$result);
179-
let assemblyFormat = [{
180-
$source
181-
(`padding_value` `(` $padding_value^ `:` type($padding_value) `)`)?
182-
(`outer_dims_perm` `=` $outer_dims_perm^)?
183-
`inner_dims_pos` `=` $inner_dims_pos
184-
`inner_tiles` `=`
185-
custom<DynamicIndexList>($inner_tiles, $static_inner_tiles)
186-
`into` $dest attr-dict `:` type($source) `->` type($dest)
187-
}];
178+
let results = (outs Optional<AnyRankedTensor>:$result);
179+
180+
let hasCustomAssemblyFormat = 1;
188181

189182
let builders = [
190183
OpBuilder<(ins "Value":$source, "Value":$dest,
@@ -335,15 +328,9 @@ def Linalg_UnPackOp : Linalg_RelayoutOp<"unpack"> {
335328
DenseI64ArrayAttr:$inner_dims_pos,
336329
Variadic<Index>:$inner_tiles,
337330
DenseI64ArrayAttr:$static_inner_tiles);
338-
let results = (outs AnyShaped:$result);
339-
let assemblyFormat = [{
340-
$source
341-
(`outer_dims_perm` `=` $outer_dims_perm^)?
342-
`inner_dims_pos` `=` $inner_dims_pos
343-
`inner_tiles` `=`
344-
custom<DynamicIndexList>($inner_tiles, $static_inner_tiles)
345-
`into` $dest attr-dict `:` type($source) `->` type($dest)
346-
}];
331+
let results = (outs Optional<AnyRankedTensor>:$result);
332+
333+
let hasCustomAssemblyFormat = 1;
347334

348335
let builders = [
349336
OpBuilder<(ins "Value":$source, "Value":$dest,

0 commit comments

Comments
 (0)