Skip to content

Commit 8f36035

Browse files
committed
ARM: Remove redundant or buggy config of __aeabi_d2h
This was set if `TT.isTargetAEABI()`. This was previously set above if `TM.isAAPCS_ABI() && (TT.isTargetAEABI() || TT.isTargetGNUAEABI() || TT.isTargetMuslAEABI() || TT.isAndroid())`. So this could differ based on a manually specified -target-abi flag due to the `isAAPCS_ABI` part of the original condition. I'm guessing these should be consistent, so either this second group of setLibcallImpl calls should have been guarded by the `isAAPCS_ABI` check, or the first condition should remove it. There doesn't appear to be any meaningful test coverage using the manually specified ABI option, so #152108 tries to remove it
1 parent dc7c3c2 commit 8f36035

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

llvm/lib/Target/ARM/ARMISelLowering.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,6 @@ ARMTargetLowering::ARMTargetLowering(const TargetMachine &TM_,
737737
const RTLIB::LibcallImpl Impl;
738738
} LibraryCalls[] = {
739739
{RTLIB::FPROUND_F32_F16, RTLIB::__aeabi_f2h},
740-
{RTLIB::FPROUND_F64_F16, RTLIB::__aeabi_d2h},
741740
{RTLIB::FPEXT_F16_F32, RTLIB::__aeabi_h2f},
742741
};
743742

0 commit comments

Comments
 (0)