Skip to content

Commit 968b238

Browse files
[CI][Github] Version pin packages in windows container
I spent several hours debugging failures in the server 2022 container today that turned out to be related to a new ninja release from a couple weeks ago. This patch version pins all the packages so they do not spuriously upgrade and we can control the process to waste less effort debugging changes due to version changes. Reviewers: cmtice, tstellar, lnihlen Reviewed By: cmtice Pull Request: #148319
1 parent 2244f57 commit 968b238

File tree

1 file changed

+7
-2
lines changed
  • .github/workflows/containers/github-action-ci-windows

1 file changed

+7
-2
lines changed

.github/workflows/containers/github-action-ci-windows/Dockerfile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,16 @@ RUN regsvr32 /S "C:\BuildTools\DIA SDK\bin\amd64\msdia140.dll" & \
3939

4040
# install tools as described in https://llvm.org/docs/GettingStartedVS.html
4141
# and a few more that were not documented...
42-
RUN choco install -y ninja git sccache
4342
# Pin an older version of Python; the current Python 3.10 fails when
4443
# doing "pip install" for the other dependencies, as it fails to find libxml
4544
# while compiling some package.
46-
RUN choco install -y python3 --version 3.9.7
45+
# We version pin the other packages as well to ensure the container build is as
46+
# reproducible as possible to prevent issues when upgrading only part of the
47+
# container.
48+
RUN choco install -y ninja --version 1.13.1 && \
49+
choco install -y git --version 2.50.1 && \
50+
choco install -y sccache --version 0.10.0 && \
51+
choco install -y python3 --version 3.9.7
4752

4853
# Testing requires psutil
4954
RUN pip install psutil

0 commit comments

Comments
 (0)