Skip to content

Commit a688ec2

Browse files
committed
Spell out the not obvious types
1 parent 0833b2a commit a688ec2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ LogicalResult GPUModuleConversion::matchAndRewrite(
385385
if (auto attr = moduleOp->getAttrOfType<spirv::TargetEnvAttr>(
386386
spirv::getTargetEnvAttrName()))
387387
spvModule->setAttr(spirv::getTargetEnvAttrName(), attr);
388-
for (auto targetAttr : moduleOp.getTargetsAttr())
388+
for (const Attribute &targetAttr : moduleOp.getTargetsAttr())
389389
if (auto spirvTargetEnvAttr = dyn_cast<spirv::TargetEnvAttr>(targetAttr))
390390
spvModule->setAttr(spirv::getTargetEnvAttrName(), spirvTargetEnvAttr);
391391

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRVPass.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ struct GPUToSPIRVPass final : impl::ConvertGPUToSPIRVBase<GPUToSPIRVPass> {
5555

5656
spirv::TargetEnvAttr
5757
GPUToSPIRVPass::lookupTargetEnvInTargets(gpu::GPUModuleOp moduleOp) {
58-
for (auto &targetAttr : moduleOp.getTargetsAttr())
58+
for (const Attribute &targetAttr : moduleOp.getTargetsAttr())
5959
if (auto spirvTargetEnvAttr = dyn_cast<spirv::TargetEnvAttr>(targetAttr))
6060
return spirvTargetEnvAttr;
6161

@@ -64,7 +64,7 @@ GPUToSPIRVPass::lookupTargetEnvInTargets(gpu::GPUModuleOp moduleOp) {
6464

6565
spirv::TargetEnvAttr
6666
GPUToSPIRVPass::lookupTargetEnvOrDefault(gpu::GPUModuleOp moduleOp) {
67-
if (auto targetEnvAttr = lookupTargetEnvInTargets(moduleOp))
67+
if (spirv::TargetEnvAttr targetEnvAttr = lookupTargetEnvInTargets(moduleOp))
6868
return targetEnvAttr;
6969

7070
return spirv::lookupTargetEnvOrDefault(moduleOp);

0 commit comments

Comments
 (0)