Skip to content

Commit b1aece9

Browse files
authored
LangRef: allocated objects can grow (#141338)
This enables the (reasonably common) pattern of using `mmap` to reserve but not actually map a wide range of pages, and then only adding in more pages as memory is actually needed. Effectively, that region of memory is one big allocated object for LLVM, but crucially, that allocated object *changes its size*. Having an allocated object grow seems entirely compatible with what LLVM optimizations assume, *except* that when LLVM sees an `alloca` or similar instruction, it will assume that a pointer that has been `getelementptr inbounds` by more than the size of the allocated object cannot alias that `alloca`. But for allocated objects that are created e.g. by `mmap`, where LLVM does not know their size, this cannot happen anyway. The other main point to be concerned about is having a `getelementptr inbounds` that is moved up across an operation that grows an allocated object: this should be legal as `getelementptr` is freely reorderable. We achieve that by saying that for allocated objects that change their size, "inbounds" means "inbounds of their maximal size", not "inbounds of their current size". It would be nice to also allow shrinking allocations (e.g. by `munmap`ing pages at the end), but that is more tricky. Consider an example like this: - load 4 bytes from `ptr` - call some function - load 1 byte from `ptr` Right now, LLVM could argue that since `ptr` clearly has not been deallocated, there must be at least 4 bytes of dereferenceable memory behind `ptr` after the call. If allocations can shrink, this kind of reasoning is no longer valid. I don't know if LLVM actually does reasoning like that -- I think it should not, since I think it should be possible to have allocations that shrink -- but to remain conservative I am not proposing that as part of this patch.
1 parent 6c50e2b commit b1aece9

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

llvm/docs/LangRef.rst

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3356,6 +3356,19 @@ behavior is undefined:
33563356
- the size of all allocated objects must be non-negative and not exceed the
33573357
largest signed integer that fits into the index type.
33583358

3359+
Allocated objects that are created with operations recognized by LLVM (such as
3360+
:ref:`alloca <i_alloca>`, heap allocation functions marked as such, and global
3361+
variables) may *not* change their size. (``realloc``-style operations do not
3362+
change the size of an existing allocated object; instead, they create a new
3363+
allocated object. Even if the object is at the same location as the old one, old
3364+
pointers cannot be used to access this new object.) However, allocated objects
3365+
can also be created by means not recognized by LLVM, e.g. by directly calling
3366+
``mmap``. Those allocated objects are allowed to grow to the right (i.e.,
3367+
keeping the same base address, but increasing their size) while maintaining the
3368+
validity of existing pointers, as long as they always satisfy the properties
3369+
described above. Currently, allocated objects are not permitted to grow to the
3370+
left or to shrink, nor can they have holes.
3371+
33593372
.. _objectlifetime:
33603373

33613374
Object Lifetime
@@ -11928,6 +11941,9 @@ if the ``getelementptr`` has any non-zero indices, the following rules apply:
1192811941
:ref:`based <pointeraliasing>` on. This means that it points into that
1192911942
allocated object, or to its end. Note that the object does not have to be
1193011943
live anymore; being in-bounds of a deallocated object is sufficient.
11944+
If the allocated object can grow, then the relevant size for being *in
11945+
bounds* is the maximal size the object could have while satisfying the
11946+
allocated object rules, not its current size.
1193111947
* During the successive addition of offsets to the address, the resulting
1193211948
pointer must remain *in bounds* of the allocated object at each step.
1193311949

0 commit comments

Comments
 (0)