Respond to feedback

Author: RossBrunton

offload/include/Shared/APITypes.h

@@ -77,8 +77,6 @@ struct __tgt_async_info {
   llvm::SmallVector<void *, 2> AssociatedAllocations;
 
   /// Mutex to guard access to AssociatedAllocations and the Queue.
-  /// This is only used for liboffload and should be ignored in libomptarget
-  /// code.
   std::mutex Mutex;
 
   /// The kernel launch environment used to issue a kernel. Stored here to

offload/liboffload/src/OffloadImpl.cpp

@@ -486,7 +486,8 @@ Error olSyncQueue_impl(ol_queue_handle_t Queue) {
   // on it, but we have nothing to synchronize in that situation anyway.
   if (Queue->AsyncInfo->Queue) {
     // We don't need to release the queue and we would like the ability for
-    // other offload threads to submit work concurrently, so pass "false" here.
+    // other offload threads to submit work concurrently, so pass "false" here
+    // so we don't release the underlying queue object.
     if (auto Err = Queue->Device->Device->synchronize(Queue->AsyncInfo, false))
       return Err;
   }

offload/plugins-nextgen/common/include/PluginInterface.h

@@ -119,7 +119,7 @@ struct AsyncInfoWrapperTy {
   /// Register \p Ptr as an associated allocation that is freed after
   /// finalization.
   void freeAllocationAfterSynchronization(void *Ptr) {
-    std::lock_guard<std::mutex> AllocationGuard{AsyncInfoPtr->Mutex};
+    std::lock_guard<std::mutex> AllocationGuard(AsyncInfoPtr->Mutex);
     AsyncInfoPtr->AssociatedAllocations.push_back(Ptr);
   }