Skip to content

Commit d58d925

Browse files
committed
implement feedback
1 parent 123f7eb commit d58d925

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3039,16 +3039,10 @@ bool IRTranslator::translateCallBr(const User &U,
30393039
if (!translateInlineAsm(I, MIRBuilder))
30403040
return false;
30413041
} else if (I.getIntrinsicID() != Intrinsic::not_intrinsic) {
3042-
switch (I.getIntrinsicID()) {
3043-
default:
3044-
report_fatal_error("Unsupported intrinsic for callbr");
3045-
case Intrinsic::amdgcn_kill:
3046-
if (!translateTargetIntrinsic(I, Intrinsic::amdgcn_kill, MIRBuilder))
3047-
return false;
3048-
break;
3049-
}
3042+
if (!translateTargetIntrinsic(I, I.getIntrinsicID(), MIRBuilder))
3043+
return false;
30503044
} else {
3051-
report_fatal_error("Only know how to handle inlineasm/intrinsic callbr");
3045+
return false;
30523046
}
30533047

30543048
// Retrieve successors.

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3402,15 +3402,9 @@ void SelectionDAGBuilder::visitCallBr(const CallBrInst &I) {
34023402
if (I.isInlineAsm()) {
34033403
visitInlineAsm(I);
34043404
} else if (I.getIntrinsicID() != Intrinsic::not_intrinsic) {
3405-
switch (I.getIntrinsicID()) {
3406-
default:
3407-
report_fatal_error("Unsupported intrinsic for callbr");
3408-
case Intrinsic::amdgcn_kill:
3409-
visitCallBrIntrinsic(I);
3410-
break;
3411-
}
3405+
visitCallBrIntrinsic(I);
34123406
} else {
3413-
report_fatal_error("Only know how to handle inlineasm/intrinsic callbr");
3407+
report_fatal_error("only know how to handle inlineasm/intrinsic callbr");
34143408
}
34153409
CopyToExportRegsIfNeeded(&I);
34163410

0 commit comments

Comments
 (0)