[BOLT][RISCV]fix up GOT Relocation Handling

Author: yjn

bolt/lib/Passes/FixRISCVCallsPass.cpp

@@ -34,7 +34,7 @@ void FixRISCVCallsPass::runOnFunction(BinaryFunction &BF) {
           TargetSym = MIB->getPCRelLoSymbol(AInst);
           if (TargetSym) {
               auto BI = II;
-              bool found = false;
+              bool foundSymbol = false;
               while(BI != BB.begin()){
                   auto *Label = MIB->getInstLabel(*BI);
                   if (Label && Label == TargetSym) {
@@ -48,6 +48,16 @@ void FixRISCVCallsPass::runOnFunction(BinaryFunction &BF) {
                 MIB->copyAnnotations(*BI, SavedInst);
                 BB.eraseInstruction(BI);
                 II = BB.insertInstruction(--II, std::move(SavedInst));
+
+                // Verify that the label of the current instruction matches 
+                // the getPCRelLoSymbol of the next instruction
+                auto NextII = std::next(II);
+                if (NextII != BB.end()) {
+                  auto *CurrentLabel = MIB->getInstLabel(*II);
+                  auto *NextTargetSym = MIB->getPCRelLoSymbol(*NextII);
+                  assert(CurrentLabel && NextTargetSym && CurrentLabel == NextTargetSym &&
+                         "Label and target symbol mismatch after instruction reordering");
+                }
                 II++;
               }
           }