include profile data, warning suppressions, etc. in clang crash reports

[zmodem]

Currently there are a bunch of compiler inputs which don't get included in Clang crash reports. For example:

$ cat /tmp/a.c
#pragma clang __debug crash
$ build/bin/clang -c /tmp/a.c -fprofile-use=a.profdata --warning-suppression-mappings=suppress.txt
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
[...]
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/a-3c1def.c
clang: note: diagnostic msg: /tmp/a-3c1def.sh
clang: note: diagnostic msg: 

********************

In this case, /tmp/a-3c1def.sh and /tmp/a-3c1def.c may not be enough to reproduce the problem (on another machine for example). It would be great if the profile, warning suppressions, and all other inputs could also be copied to the -fcrash-diagnostics-dir and the run script updated accordingly.

[llvmbot]

@llvm/issue-subscribers-clang-driver

Author: Hans Wennborg (zmodem)

Currently there are a bunch of compiler inputs which don't get included in Clang crash reports. For example:

$ cat /tmp/a.c
#pragma clang __debug crash
$ build/bin/clang -c /tmp/a.c -fprofile-use=a.profdata --warning-suppression-mappings=suppress.txt
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
[...]
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/a-3c1def.c
clang: note: diagnostic msg: /tmp/a-3c1def.sh
clang: note: diagnostic msg: 

********************

In this case, /tmp/a-3c1def.sh and /tmp/a-3c1def.c may not be enough to reproduce the problem (on another machine for example). It would be great if the profile, warning suppressions, and all other inputs could also be copied to the -fcrash-diagnostics-dir and the run script updated accordingly.

[nico]

Possible inspiration: 7aff2bb

[nico]

Here's what a test for --wsm could look like:

% cat clang/test/Driver/crash-report-wsm.cpp     
// RUN: rm -rf %t
// RUN: mkdir %t
// RUN: split-file %s %t

// RUN: not %clang %t/main.c --warning-suppression-mappings=%t/suppress.txt \
// RUN:         -c -gen-reproducer -fcrash-diagnostics-dir=%t/crash

// RUN: cat %t/crash/main-*.sh | FileCheck --check-prefix=CHECKSH -DDIR=%t %s

// RUN: cat %t/crash/suppress-*.txt | FileCheck --check-prefix=CHECKSUPP %s

// CHECKSH: # Crash reproducer
// CHECKSH-NEXT: # Driver args:
// CHECKSH-SAME: "--warning-suppression-mappings=[[DIR]]/suppress.txt"
// CHECKSH-NEXT: # Original command:
// CHECKSH-SAME: "--warning-suppression-mappings=[[DIR]]/suppress.txt"
// CHECKSH-NEXT: "-cc1"
// CHECKSH-SAME: "--warning-suppression-mappings=suppress.txt"

// CHECKSUPP: # Empty suppression file

//--- main.c

//--- suppress.txt

# Empty suppression file

I wonder if --wsm synergizes with the line directives in the post-preprocessor files in repo directories. If not, bundling the file doesn't help all that much.