Skip to content

Conversation

ashgti
Copy link
Contributor

@ashgti ashgti commented Oct 4, 2025

These tests are failing on win32 platforms, disabling while I investigate the root cause.

These tests are failing on win32 platforms, disabling while I investigate the root cause.
@ashgti ashgti marked this pull request as ready for review October 4, 2025 01:00
@ashgti ashgti requested a review from JDevlieghere as a code owner October 4, 2025 01:00
@llvmbot llvmbot added the lldb label Oct 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 4, 2025

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

Changes

These tests are failing on win32 platforms, disabling while I investigate the root cause.


Full diff: https://github.com/llvm/llvm-project/pull/161931.diff

2 Files Affected:

  • (modified) lldb/unittests/Protocol/ProtocolMCPServerTest.cpp (+5)
  • (modified) lldb/unittests/Protocol/ProtocolMCPTest.cpp (+5)
diff --git a/lldb/unittests/Protocol/ProtocolMCPServerTest.cpp b/lldb/unittests/Protocol/ProtocolMCPServerTest.cpp
index 9628cbd91e9ce..45464db958e04 100644
--- a/lldb/unittests/Protocol/ProtocolMCPServerTest.cpp
+++ b/lldb/unittests/Protocol/ProtocolMCPServerTest.cpp
@@ -38,6 +38,9 @@ using namespace lldb_private;
 using namespace lldb_private::transport;
 using namespace lldb_protocol::mcp;
 
+// Flakey, see https://github.com/llvm/llvm-project/issues/152677.
+#ifndef _WIN32
+
 namespace {
 
 template <typename T> Response make_response(T &&result, Id id = 1) {
@@ -325,3 +328,5 @@ TEST_F(ProtocolServerMCPTest, NotificationInitialized) {
   EXPECT_THAT(logged_messages,
               testing::Contains("MCP initialization complete"));
 }
+
+#endif
diff --git a/lldb/unittests/Protocol/ProtocolMCPTest.cpp b/lldb/unittests/Protocol/ProtocolMCPTest.cpp
index 396e361e873fe..5f7391e43fe34 100644
--- a/lldb/unittests/Protocol/ProtocolMCPTest.cpp
+++ b/lldb/unittests/Protocol/ProtocolMCPTest.cpp
@@ -16,6 +16,9 @@ using namespace lldb;
 using namespace lldb_private;
 using namespace lldb_protocol::mcp;
 
+// Flakey, see https://github.com/llvm/llvm-project/issues/152677.
+#ifndef _WIN32
+
 TEST(ProtocolMCPTest, Request) {
   Request request;
   request.id = 1;
@@ -292,3 +295,5 @@ TEST(ProtocolMCPTest, ReadResourceResultEmpty) {
 
   EXPECT_TRUE(deserialized_result->contents.empty());
 }
+
+#endif

@ashgti
Copy link
Contributor Author

ashgti commented Oct 4, 2025

Submitting to unblock CI.

@ashgti ashgti merged commit f3673c5 into llvm:main Oct 4, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants