[MLGO] Fix feature iteration using FeatureMap.size() instead of NumberOfFeatures #146436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
svkeerthy
changed the title
llvmbot
added
the
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis Author: S. VenkataKeerthy (svkeerthy) ChangesDue to the changes made in #143479, size of Full diff: https://github.com/llvm/llvm-project/pull/146436.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp b/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
index e7e8f2ac1ff25..fcaa32750b7ab 100644
--- a/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
+++ b/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
@@ -27,8 +27,8 @@
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/ManagedStatic.h"
-#include <vector>
#include <optional>
+#include <vector>
using namespace llvm;
@@ -260,7 +260,7 @@ static const std::vector<TensorSpec> TrainingOnlyFeatures{
static const std::vector<TensorSpec> getInputFeatures() {
std::vector<TensorSpec> InputSpecs;
- for (size_t I = 0; I < NumberOfFeatures; ++I)
+ for (size_t I = 0; I < FeatureMap.size(); ++I)
InputSpecs.push_back(
TensorSpec(TFFeedPrefix + FeatureMap[I].name(), FeatureMap[I]));
append_range(InputSpecs, TrainingOnlyFeatures);
@@ -299,7 +299,7 @@ void TrainingLogger::logInlineEvent(const InlineEvent &Event,
const MLModelRunner &ModelRunner) {
L->startObservation();
size_t CurrentFeature = 0;
- for (; CurrentFeature < NumberOfFeatures; ++CurrentFeature)
+ for (; CurrentFeature < FeatureMap.size(); ++CurrentFeature)
L->logTensorValue(CurrentFeature,
reinterpret_cast<const char *>(
ModelRunner.getTensorUntyped(CurrentFeature)));
|
svkeerthy
force-pushed
the
users/svkeerthy/07-01-developmentmodemr_fixes
branch
from
a3cdb1b to
e231124
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces hardcoded NumberOfFeatures iterations with dynamic FeatureMap.size() and modernizes loops accordingly.
- Switched to a range-based loop in
getInputFeatures - Cached
FeatureMap.size()for iteration inlogInlineEvent - Adjusted include ordering
Comments suppressed due to low confidence (2)
llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:263
- [nitpick] The loop variable
Featureis capitalized like a type and may shadow other symbols; consider renaming it tofeatureor a more descriptive name such asfeatureSpec.
for (const auto &Feature : FeatureMap)
llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:263
- Now that
NumberOfFeaturesis no longer used, its definition can be removed from the codebase to avoid dead code and potential confusion.
for (const auto &Feature : FeatureMap)
| TensorSpec::createSpec<int32_t>(TFFeedPrefix + "step_type", {1})}; | ||
|
|
||
| static const std::vector<TensorSpec> getInputFeatures() { | ||
| std::vector<TensorSpec> InputSpecs; |
There was a problem hiding this comment.
[nitpick] Reserve the expected capacity for InputSpecs (e.g., InputSpecs.reserve(FeatureMap.size() + TrainingOnlyFeatures.size());) to avoid multiple reallocations during push_back.
Suggested change
| std::vector<TensorSpec> InputSpecs; | |
| std::vector<TensorSpec> InputSpecs; | |
| InputSpecs.reserve(FeatureMap.size() + TrainingOnlyFeatures.size()); |
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes made in #143479, size of
FeatureMapreflects the number of features used. Hence replacingNumberOfFeatureswithFeatureMap.size()in theDevelopmentModeInlineAdvisor.