From b665c46a9c87ec54afbe3fd9d141121c64a389d5 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Fri, 18 Jul 2025 00:04:15 -0400 Subject: [PATCH] [lldb-dap] Fix type req->arguments == "disconnect" This typo was introduced in PR #140331. This branch will never get executed. We also set the `disconnecting = true` in the `DAP::Disconnect()` so I am not sure if we need it in both places. --- lldb/tools/lldb-dap/DAP.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp index fd89f52595ec6..cbd3b14463e25 100644 --- a/lldb/tools/lldb-dap/DAP.cpp +++ b/lldb/tools/lldb-dap/DAP.cpp @@ -983,7 +983,7 @@ llvm::Error DAP::Loop() { if (const protocol::Request *req = std::get_if(&*next); - req && req->arguments == "disconnect") + req && req->command == "disconnect") disconnecting = true; const std::optional cancel_args =