[opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually… #151845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kraj wants to merge 1 commit into llvm:main from kraj:kraj/opt-viewer

Contributor

kraj commented Aug 3, 2025

… from the CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES so that if the user specifies the variable on the commandline it takes precedence. If not, fall back to the old logic

llvmbot added the cmake label

Contributor

rossburton commented Aug 4, 2025

Note that the opt-viewer script is always installed anyway, even if the dependencies are not present. I'd say the same variable should be used to seed whether opt-viewer is installed or not.


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

431d4ea

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Do not install opt-viewer of the modules are not found. Since the python
scripts have dependencies on these modules, it makes not much point to
have them installed.

kraj force-pushed the kraj/opt-viewer branch from 6856481 to 431d4ea Compare

August 5, 2025 16:05

Contributor

rossburton commented Aug 5, 2025

I know that LLVM currently has all the detection logic embedded in AddLLVM.cmake, is that by design or just how it's happened? It feels like it could be moved into llvm/tools/opt-viewer/CMakeLists.txt which would then also automatically not run if LLVM_TOOL_OPT_VIEWER_BUILD was OFF.

kraj added a commit to kraj/llvm-project that referenced this pull request


          [opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually…

04005b0

… from the CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]
Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

38b72b7

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

ae4d978

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

f8e3717

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          [opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually…

c2b576a

… from the CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]
Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

80f50f3

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

e84b204

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          [opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually…

1045d7a

… from the CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]
Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

662f28b

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

3932a65

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

25c3a40

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          [opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually…

274bee7

… from the CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]
Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          [opt-viewer] Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually…

1f28b5b

… from the CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]
Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

069a61f

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

9f94de6

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

59e1a32

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

b9eccc4

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

kraj added a commit to kraj/llvm-project that referenced this pull request


          llvm: Allow users to set LLVM_HAVE_OPT_VIEWER_MODULES manually from t…

e6ae5af

…he CMake

Check right before setting LLVM_HAVE_OPT_VIEWER_MODULES
so that if the user specifies the variable on the commandline
it takes precedence. If not, fall back to the old logic

Upstream-Status: Submitted [llvm#151845]

Signed-off-by: Khem Raj <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake