Fix handling of dontcall attributes for arches that lower calls via fastSelectInstruction #153302
Conversation
…astSelectInstruction
|
@llvm/pr-subscribers-backend-arm @llvm/pr-subscribers-backend-webassembly Author: Daniel Paoliello (dpaoliello) ChangesRecently my change to avoid duplicate The root cause is that, if the default I've checked the other implementations of Full diff: https://github.com/llvm/llvm-project/pull/153302.diff 2 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMFastISel.cpp b/llvm/lib/Target/ARM/ARMFastISel.cpp
index 54aa355d4db0a..14e1160e70dae 100644
--- a/llvm/lib/Target/ARM/ARMFastISel.cpp
+++ b/llvm/lib/Target/ARM/ARMFastISel.cpp
@@ -2504,6 +2504,7 @@ bool ARMFastISel::SelectCall(const Instruction *I,
// Set all unused physreg defs as dead.
static_cast<MachineInstr *>(MIB)->setPhysRegsDeadExcept(UsedRegs, TRI);
+ diagnoseDontCall(*CI);
return true;
}
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
index ec95e86e4fe3d..2666342d0c7b9 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
@@ -912,6 +912,8 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I) {
if (!IsVoid)
updateValueMap(Call, ResultReg);
+
+ diagnoseDontCall(*Call);
return true;
}
|
3 participants
Recently my change to avoid duplicate
dontcallattribute errors (#152810) caused the ClangFrontend/backend-attribute-error-warning.ctest to fail on Arm32: https://lab.llvm.org/buildbot/#/builders/154/builds/20134The root cause is that, if the default
IFastSelpath bails, then targets are given the opportunity to lower instructions viafastSelectInstruction. That's the path taken by Arm32 and since its implementation ofselectCalldidn't calldiagnoseDontCallno error was emitted.I've checked the other implementations of
fastSelectInstructionand the only other one that lowers call instructions in WebAssembly, so I've fixed that too.