Add torch.aten.as_strided to tensor.extract_slice conversion #4268
+145
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michizhou Did you check the test locally? Was it working? I tested your patch and the lowering does not seem to work. |
|
Hi @michizhou, I have added the support for this op here: #4269 since it was blocking us. You can close this PR now. Sorry, it was a priority issue hence I go ahead and fixed it. |
|
Hi @vivekkhandelwal1, no worries I completely understand. Thank you so much for taking up the work to add E2E support for this op in your PR. I will go ahead with closing this PR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for conversion of
torch.aten.as_stridedops totensor.extract_sliceops. Certain MoE models like DeepSeek V3 have multiple instances of theas_stridedop included in their top-level IRs. As a result, this pattern is required to support the lowering of such models in pipelines like the Torch to Linalg IR backend conversion pipeline. Otherwise, leavingas_stridedops as-is causes some dependenttorch.constant.intops to be retained (for which legalization should not be supported).