fix(build): resolve SemVer packaging and CI/CD workflow issues

- Fix versioning bug preventing package deployment by switching from build metadata format (2.0.0+date.sha) to pre-release format (2.0.0-nightly.date.sha) for NuGet filename compatibility
- Eliminate duplicate CI/CD runs by removing feature/* branches from push triggers and implementing PR-driven deployments for feature branches
- Update GitHub Actions workflow branch name detection using conditional expressions for both push and pull_request events
- Ensure proper SemVer 2.0 compliance where feature branch packages (2.0.0-source-generator-*) rank higher than nightly builds (2.0.0-nightly.*) due to lexicographic ordering
- Maintain backward compatibility with existing versioning strategy while enabling reliable automated package publishing

Affects packages:
- LocalStack.Client
- LocalStack.Client.Extensions

Author: Blind-Striker

.github/workflows/ci-cd.yml

@@ -7,7 +7,6 @@ on:
       - LICENSE
     branches:
       - "master"
-      - "feature/*"
   pull_request:
     paths-ignore:
       - "**.md"
@@ -124,8 +123,8 @@ jobs:
     needs: build-and-test
     if: |
       github.repository == 'localstack-dotnet/localstack-dotnet-client' &&
-      github.event_name == 'push' &&
-      (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/feature/'))
+      ((github.event_name == 'push' && github.ref == 'refs/heads/master') ||
+       (github.event_name == 'pull_request' && startsWith(github.head_ref, 'feature/')))
     env:
       NUGET_PACKAGES: ${{ github.workspace }}/.nuget/packages
 
@@ -186,7 +185,7 @@ jobs:
             --package-source github \
             --package-id LocalStack.Client \
             --use-directory-props-version true \
-            --branch-name ${{ github.ref_name }} \
+            --branch-name ${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }} \
             --package-secret ${{ secrets.GITHUB_TOKEN }}
 
       - name: "Prepare Extensions Project"
@@ -204,13 +203,13 @@ jobs:
             --package-source github \
             --package-id LocalStack.Client.Extensions \
             --use-directory-props-version true \
-            --branch-name ${{ github.ref_name }} \
+            --branch-name ${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }} \
             --package-secret ${{ secrets.GITHUB_TOKEN }}
 
       - name: "Upload Package Artifacts"
         uses: actions/upload-artifact@v4
         with:
-          name: "packages-${{ github.ref_name }}-${{ github.run_number }}"
+          name: "packages-${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }}-${{ github.run_number }}"
           path: |
             artifacts/*.nupkg
             artifacts/*.snupkg
@@ -221,7 +220,7 @@ jobs:
           echo "📦 Generating build summary..."
           ./build.sh --target workflow-summary \
             --use-directory-props-version true \
-            --branch-name ${{ github.ref_name }}
+            --branch-name ${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }}
 
       - name: "Cleanup Configuration"
         if: always()

build/LocalStack.Build/BuildContext.cs

@@ -281,16 +281,16 @@ private string GetDynamicVersionFromProps(string versionPropertyName)
         string commitSha = GetGitCommitSha();
         string safeBranchName = BranchName.Replace('/', '-').Replace('_', '-');
 
-        // Simplified NuGet-compliant version format
+        // SemVer-compliant pre-release versioning
         if (BranchName == "master")
         {
-            // Nightly off main — use build metadata
-            return $"{baseVersion}+{buildDate}.{commitSha}";
+            // Master nightlies: 2.0.0-nightly.20250725.sha
+            return $"{baseVersion}-nightly.{buildDate}.{commitSha}";
         }
         else
         {
-            // Feature branch / preview line
-            return $"{baseVersion}.{safeBranchName}.{buildDate}.{commitSha}";
+            // Feature branches: 2.0.0-feature-name.20250725.sha  
+            return $"{baseVersion}-{safeBranchName}.{buildDate}.{commitSha}";
         }
     }