From 361f9895f037de651abc474d367cad5cc3f8ee95 Mon Sep 17 00:00:00 2001 From: fryorcraken Date: Thu, 13 Nov 2025 11:58:22 +1100 Subject: [PATCH 1/2] test: unskip tests Now that the global state is not polluted anymore. --- packages/sdk/src/reliable_channel/reliable_channel.spec.ts | 2 +- .../reliable_channel/reliable_channel_encryption.spec.ts | 3 +-- packages/sds/src/message_channel/message_channel.spec.ts | 6 ++---- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/sdk/src/reliable_channel/reliable_channel.spec.ts b/packages/sdk/src/reliable_channel/reliable_channel.spec.ts index 22ad4062ce..c210f54dda 100644 --- a/packages/sdk/src/reliable_channel/reliable_channel.spec.ts +++ b/packages/sdk/src/reliable_channel/reliable_channel.spec.ts @@ -186,7 +186,7 @@ describe("Reliable Channel", () => { }); // TODO: https://github.com/waku-org/js-waku/issues/2648 - it.skip("Outgoing message is possibly acknowledged", async () => { + it("Outgoing message is possibly acknowledged", async () => { const commonEventEmitter = new TypedEventEmitter(); const mockWakuNodeAlice = new MockWakuNode(commonEventEmitter); const mockWakuNodeBob = new MockWakuNode(commonEventEmitter); diff --git a/packages/sdk/src/reliable_channel/reliable_channel_encryption.spec.ts b/packages/sdk/src/reliable_channel/reliable_channel_encryption.spec.ts index 628c99bfaa..978d357ec6 100644 --- a/packages/sdk/src/reliable_channel/reliable_channel_encryption.spec.ts +++ b/packages/sdk/src/reliable_channel/reliable_channel_encryption.spec.ts @@ -187,8 +187,7 @@ describe("Reliable Channel: Encryption", () => { expect(messageAcknowledged).to.be.false; }); - // TODO: https://github.com/waku-org/js-waku/issues/2648 - it.skip("Outgoing message is possibly acknowledged", async () => { + it("Outgoing message is possibly acknowledged", async () => { const commonEventEmitter = new TypedEventEmitter(); const mockWakuNodeAlice = new MockWakuNode(commonEventEmitter); const mockWakuNodeBob = new MockWakuNode(commonEventEmitter); diff --git a/packages/sds/src/message_channel/message_channel.spec.ts b/packages/sds/src/message_channel/message_channel.spec.ts index ea1629250c..4108c5a271 100644 --- a/packages/sds/src/message_channel/message_channel.spec.ts +++ b/packages/sds/src/message_channel/message_channel.spec.ts @@ -185,8 +185,7 @@ describe("MessageChannel", function () { expect(timestampAfter).to.equal(timestampBefore + 1n); }); - // TODO: test is failing in CI, investigate in https://github.com/waku-org/js-waku/issues/2648 - it.skip("should update lamport timestamp if greater than current timestamp and dependencies are met", async () => { + it("should update lamport timestamp if greater than current timestamp and dependencies are met", async () => { const testChannelA = new MessageChannel(channelId, "alice"); const testChannelB = new MessageChannel(channelId, "bob"); @@ -207,8 +206,7 @@ describe("MessageChannel", function () { ); }); - // TODO: test is failing in CI, investigate in https://github.com/waku-org/js-waku/issues/2648 - it.skip("should maintain proper timestamps if all messages received", async () => { + it("should maintain proper timestamps if all messages received", async () => { const aTimestampBefore = channelA["lamportTimestamp"]; let timestamp = channelB["lamportTimestamp"]; for (const m of messagesA) { From 9787f1d8edcc159704937f56be96dc9ab66e7959 Mon Sep 17 00:00:00 2001 From: fryorcraken Date: Tue, 18 Nov 2025 16:35:25 -0300 Subject: [PATCH 2/2] test: timestamp is not strictly incremental --- packages/sds/src/message_channel/message_channel.spec.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/sds/src/message_channel/message_channel.spec.ts b/packages/sds/src/message_channel/message_channel.spec.ts index 4108c5a271..67ce043722 100644 --- a/packages/sds/src/message_channel/message_channel.spec.ts +++ b/packages/sds/src/message_channel/message_channel.spec.ts @@ -201,9 +201,8 @@ describe("MessageChannel", function () { }); } const timestampAfter = testChannelA["lamportTimestamp"]; - expect(timestampAfter - timestampBefore).to.equal( - BigInt(messagesB.length) - ); + // The timestamp must increase by at leat the number of messages. + expect(timestampAfter - timestampBefore >= messagesB.length).to.be.true; }); it("should maintain proper timestamps if all messages received", async () => {