Refine logging (#27)

uhoefel · luhenry · web-flow · commit 519b2ca0b2d2 · 2025-09-11T19:38:42.000+02:00
* bump JUnit version * Refine logging Explicitly state what has been loaded, and show failures only upon a sufficient logging level, as they should not hamper correct operation * Use UncheckedIOException instead of RuntimeException for caught IOE * Add the throwable to the fine grained logging message Should help with #20 * Fix logging for throwable info * Fix whitespace * Simplify dumping which blas/lapack/arpack we are using --------- Co-authored-by: Ludovic Henry <git@ludovic.dev>
diff --git a/arpack/pom.xml b/arpack/pom.xml
@@ -42,7 +42,7 @@ information or have any questions.
   <packaging>jar</packaging>
 
   <properties>
-    <junit.version>5.8.2</junit.version>
+    <junit.version>5.13.4</junit.version>
     <automatic.module.name>dev.ludovic.netlib.arpack</automatic.module.name>
   </properties>
 
diff --git a/arpack/src/main/java/dev/ludovic/netlib/arpack/InstanceBuilder.java b/arpack/src/main/java/dev/ludovic/netlib/arpack/InstanceBuilder.java
@@ -25,6 +25,7 @@
 
 package dev.ludovic.netlib.arpack;
 
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 final class InstanceBuilder {
@@ -39,6 +40,8 @@ final class InstanceBuilder {
     nativeArpack = initializeNative();
     javaArpack = initializeJava();
     arpack = nativeArpack != null ? nativeArpack : javaArpack;
+
+    log.info("Using " + arpack.getClass().getName());
   }
 
   public static ARPACK arpack() {
@@ -49,7 +52,7 @@ private static NativeARPACK initializeNative() {
     try {
       return JNIARPACK.getInstance();
     } catch (Throwable t) {
-      log.warning("Failed to load implementation from:" + JNIARPACK.class.getName());
+      log.log(Level.FINE, "Failed to load implementation from:" + JNIARPACK.class.getName(), t);
       return null;
     }
   }
diff --git a/arpack/src/main/java/dev/ludovic/netlib/arpack/JNIARPACK.java b/arpack/src/main/java/dev/ludovic/netlib/arpack/JNIARPACK.java
@@ -25,8 +25,9 @@
 
 package dev.ludovic.netlib.arpack;
 
-import java.io.InputStream;
 import java.io.IOException;
+import java.io.InputStream;
+import java.io.UncheckedIOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.StandardCopyOption;
@@ -55,7 +56,7 @@ protected JNIARPACK() {
                   StandardCopyOption.REPLACE_EXISTING);
       temp.toFile().deleteOnExit();
     } catch (IOException e) {
-      throw new RuntimeException("Unable to load native implementation", e);
+      throw new UncheckedIOException("Unable to load native implementation", e);
     }
 
     System.load(temp.toString());
diff --git a/blas/pom.xml b/blas/pom.xml
@@ -42,7 +42,7 @@ information or have any questions.
   <packaging>jar</packaging>
 
   <properties>
-    <junit.version>5.8.2</junit.version>
+    <junit.version>5.13.4</junit.version>
     <automatic.module.name>dev.ludovic.netlib.blas</automatic.module.name>
   </properties>
 
diff --git a/blas/src/main/java/dev/ludovic/netlib/blas/InstanceBuilder.java b/blas/src/main/java/dev/ludovic/netlib/blas/InstanceBuilder.java
@@ -25,6 +25,7 @@
 
 package dev.ludovic.netlib.blas;
 
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 final class InstanceBuilder {
@@ -39,6 +40,8 @@ final class InstanceBuilder {
     nativeBlas = initializeNative();
     javaBlas = initializeJava();
     blas = nativeBlas != null ? nativeBlas : javaBlas;
+
+    log.info("Using " + blas.getClass().getName());
   }
 
   public static BLAS blas() {
@@ -49,7 +52,7 @@ private static NativeBLAS initializeNative() {
     try {
       return JNIBLAS.getInstance();
     } catch (Throwable t) {
-      log.warning("Failed to load implementation from:" + JNIBLAS.class.getName());
+      log.log(Level.FINE, "Failed to load implementation from:" + JNIBLAS.class.getName(), t);
       return null;
     }
   }
@@ -69,16 +72,15 @@ private static JavaBLAS initializeJava() {
         log.finest("trying to return java 16 instance");
         return VectorBLAS.getInstance();
       } catch (Throwable t) {
-        log.warning("Failed to load implementation from:" + VectorBLAS.class.getName());
+        log.log(Level.FINE, "Failed to load implementation from:" + VectorBLAS.class.getName(), t);
       }
     }
     if (major >= 11) {
       log.finest("return java 11 instance");
       return Java11BLAS.getInstance();
-    } else {
-      log.finest("return java 8 instance");
-      return Java8BLAS.getInstance();
     }
+    log.finest("return java 8 instance");
+    return Java8BLAS.getInstance();
   }
 
   public static JavaBLAS javaBlas() {
diff --git a/blas/src/main/java/dev/ludovic/netlib/blas/JNIBLAS.java b/blas/src/main/java/dev/ludovic/netlib/blas/JNIBLAS.java
@@ -25,8 +25,9 @@
 
 package dev.ludovic.netlib.blas;
 
-import java.io.InputStream;
 import java.io.IOException;
+import java.io.InputStream;
+import java.io.UncheckedIOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.StandardCopyOption;
@@ -55,7 +56,7 @@ protected JNIBLAS() {
                   StandardCopyOption.REPLACE_EXISTING);
       temp.toFile().deleteOnExit();
     } catch (IOException e) {
-      throw new RuntimeException("Unable to load native implementation", e);
+      throw new UncheckedIOException("Unable to load native implementation", e);
     }
 
     System.load(temp.toString());
diff --git a/lapack/pom.xml b/lapack/pom.xml
@@ -42,7 +42,7 @@ information or have any questions.
   <packaging>jar</packaging>
 
   <properties>
-    <junit.version>5.8.2</junit.version>
+    <junit.version>5.13.4</junit.version>
     <automatic.module.name>dev.ludovic.netlib.lapack</automatic.module.name>
   </properties>
 
diff --git a/lapack/src/main/java/dev/ludovic/netlib/lapack/InstanceBuilder.java b/lapack/src/main/java/dev/ludovic/netlib/lapack/InstanceBuilder.java
@@ -25,6 +25,7 @@
 
 package dev.ludovic.netlib.lapack;
 
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 final class InstanceBuilder {
@@ -39,6 +40,8 @@ final class InstanceBuilder {
     nativeLapack = initializeNative();
     javaLapack = initializeJava();
     lapack = nativeLapack != null ? nativeLapack : javaLapack;
+
+    log.info("Using " + lapack.getClass().getName());
   }
 
   public static LAPACK lapack() {
@@ -49,14 +52,14 @@ private static NativeLAPACK initializeNative() {
     try {
       return JNILAPACK.getInstance();
     } catch (Throwable t) {
-      log.warning("Failed to load implementation from:" + JNILAPACK.class.getName());
+      log.log(Level.FINE, "Failed to load implementation from:" + JNILAPACK.class.getName(), t);
       return null;
     }
   }
 
   public static NativeLAPACK nativeLapack() {
     if (nativeLapack == null) {
-      throw new RuntimeException("Unable to load native implementation");
+      throw new RuntimeException("Unable to load native LAPACK implementation");
     }
     return nativeLapack;
   }
diff --git a/lapack/src/main/java/dev/ludovic/netlib/lapack/JNILAPACK.java b/lapack/src/main/java/dev/ludovic/netlib/lapack/JNILAPACK.java
@@ -26,6 +26,7 @@
 package dev.ludovic.netlib.lapack;
 
 import java.io.InputStream;
+import java.io.UncheckedIOException;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -55,10 +56,11 @@ protected JNILAPACK() {
                   StandardCopyOption.REPLACE_EXISTING);
       temp.toFile().deleteOnExit();
     } catch (IOException e) {
-      throw new RuntimeException("Unable to load native implementation", e);
+      throw new UncheckedIOException("Unable to load native implementation", e);
     }
 
-    System.load(temp.toString());}
+    System.load(temp.toString());
+  }
 
   public static NativeLAPACK getInstance() {
     return instance;

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`
`26`	`26`	`package dev.ludovic.netlib.blas;`
`27`	`27`
	`28`	`+import java.util.logging.Level;`
`28`	`29`	`import java.util.logging.Logger;`
`29`	`30`
`30`	`31`	`final class InstanceBuilder {`
`@@ -39,6 +40,8 @@ final class InstanceBuilder {`
`39`	`40`	`nativeBlas = initializeNative();`
`40`	`41`	`javaBlas = initializeJava();`
`41`	`42`	`blas = nativeBlas != null ? nativeBlas : javaBlas;`
	`43`	`+`
	`44`	`+ log.info("Using " + blas.getClass().getName());`
`42`	`45`	`}`
`43`	`46`
`44`	`47`	`public static BLAS blas() {`
`@@ -49,7 +52,7 @@ private static NativeBLAS initializeNative() {`
`49`	`52`	`try {`
`50`	`53`	`return JNIBLAS.getInstance();`
`51`	`54`	`} catch (Throwable t) {`
`52`		`- log.warning("Failed to load implementation from:" + JNIBLAS.class.getName());`
	`55`	`+ log.log(Level.FINE, "Failed to load implementation from:" + JNIBLAS.class.getName(), t);`
`53`	`56`	`return null;`
`54`	`57`	`}`
`55`	`58`	`}`
`@@ -69,16 +72,15 @@ private static JavaBLAS initializeJava() {`
`69`	`72`	`log.finest("trying to return java 16 instance");`
`70`	`73`	`return VectorBLAS.getInstance();`
`71`	`74`	`} catch (Throwable t) {`
`72`		`- log.warning("Failed to load implementation from:" + VectorBLAS.class.getName());`
	`75`	`+ log.log(Level.FINE, "Failed to load implementation from:" + VectorBLAS.class.getName(), t);`
`73`	`76`	`}`
`74`	`77`	`}`
`75`	`78`	`if (major >= 11) {`
`76`	`79`	`log.finest("return java 11 instance");`
`77`	`80`	`return Java11BLAS.getInstance();`
`78`		`- } else {`
`79`		`- log.finest("return java 8 instance");`
`80`		`- return Java8BLAS.getInstance();`
`81`	`81`	`}`
	`82`	`+ log.finest("return java 8 instance");`
	`83`	`+ return Java8BLAS.getInstance();`
`82`	`84`	`}`
`83`	`85`
`84`	`86`	`public static JavaBLAS javaBlas() {`