Merge branch 'fix/fix-background-echoes'

Author: medicalwei

src/lxterminal.c

@@ -1194,6 +1194,22 @@ static Term * terminal_new(LXTerminal * terminal, const gchar * label, const gch
     gtk_box_pack_start(GTK_BOX(term->box), term->scrollbar, FALSE, TRUE, 0);
     gtk_widget_set_no_show_all(GTK_WIDGET(term->scrollbar), TRUE);
 
+    #if GTK_CHECK_VERSION (2, 90, 8)
+    /* De-transarent box after setting gtk_widget_set_app_paintable to the
+     * GtkWindow */
+    GtkCssProvider* box_css_provider = gtk_css_provider_new();
+    gtk_css_provider_load_from_data(box_css_provider,
+        "box{background-color:@theme_bg_color;}",
+        -1, NULL
+    );
+
+    GtkStyleContext* box_style_ctx =
+        gtk_widget_get_style_context(GTK_WIDGET(terminal->box));
+    gtk_style_context_add_provider(
+        box_style_ctx, box_css_provider,
+        GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+    #endif
+
     /* Set up the VTE. */
     setlocale(LC_ALL, "");
 #if VTE_CHECK_VERSION (0, 38, 0)
@@ -1793,19 +1809,6 @@ static void terminal_settings_apply(LXTerminal * terminal)
     gboolean has_transparency = setting->background_color.alpha < 1.0;
     gtk_widget_set_app_paintable(
         GTK_WIDGET(terminal->window), has_transparency);
-
-    /* De-transarent box */
-    GtkCssProvider* box_css_provider = gtk_css_provider_new();
-    gtk_css_provider_load_from_data(box_css_provider,
-        "box{background-color:@theme_bg_color;}",
-        -1, NULL
-    );
-
-    GtkStyleContext* box_style_ctx =
-        gtk_widget_get_style_context(GTK_WIDGET(terminal->box));
-    gtk_style_context_add_provider(
-        box_style_ctx, box_css_provider,
-        GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
     #endif
 
     /* Update tab position. */