button action line number validation

Author: mProjectsCode

CHANGELOG.md

@@ -1,6 +1,6 @@
 # Obsidian Meta Bind Changelog
 
-# 1.0.0
+# 1.0.0 (UNRELEASED)
 
 New Features
 

packages/core/src/fields/button/ButtonActionRunner.ts

@@ -270,14 +270,22 @@ export class ButtonActionRunner {
 	}
 
 	async runReplaceInNoteAction(action: ReplaceInNoteButtonAction, filePath: string): Promise<void> {
-		const replacement = action.templater
-			? await this.plugin.internal.evaluateTemplaterTemplate(action.replacement, filePath)
-			: action.replacement;
+		if (action.fromLine > action.toLine) {
+			throw new Error('From line cannot be greater than to line');
+		}
 
 		const content = await this.plugin.internal.readFilePath(filePath);
 
 		let splitContent = content.split('\n');
 
+		if (action.fromLine < 0 || action.toLine > splitContent.length + 1) {
+			throw new Error('Line numbers out of bounds');
+		}
+
+		const replacement = action.templater
+			? await this.plugin.internal.evaluateTemplaterTemplate(action.replacement, filePath)
+			: action.replacement;
+
 		splitContent = [
 			...splitContent.slice(0, action.fromLine - 1),
 			replacement,
@@ -301,14 +309,22 @@ export class ButtonActionRunner {
 			throw new Error('Position of the button in the note is unknown');
 		}
 
-		const replacement = action.templater
-			? await this.plugin.internal.evaluateTemplaterTemplate(action.replacement, filePath)
-			: action.replacement;
+		if (position.lineStart > position.lineEnd) {
+			throw new Error('Position of the button in the note is invalid');
+		}
 
 		const content = await this.plugin.internal.readFilePath(filePath);
 
 		let splitContent = content.split('\n');
 
+		if (position.lineStart < 0 || position.lineEnd > splitContent.length + 1) {
+			throw new Error('Position of the button in the note is out of bounds');
+		}
+
+		const replacement = action.templater
+			? await this.plugin.internal.evaluateTemplaterTemplate(action.replacement, filePath)
+			: action.replacement;
+
 		splitContent = [
 			...splitContent.slice(0, position.lineStart),
 			replacement,
@@ -335,6 +351,10 @@ export class ButtonActionRunner {
 
 		let splitContent = content.split('\n');
 
+		if (action.line < 1 || action.line > splitContent.length + 1) {
+			throw new Error('Line number out of bounds');
+		}
+
 		const replacement = action.templater
 			? await this.plugin.internal.evaluateTemplaterTemplate(action.value, filePath)
 			: action.value;