MC-5824: Remove data migration from main Page Builder module

- Resolve static failures
- Resolve CR comments

Author: davemacaulay

app/code/Magento/PageBuilder/composer.json

@@ -3,20 +3,21 @@
     "description": "Page Builder module",
     "require": {
         "magento/framework": "*",
-        "magento/module-eav": "*",
         "magento/module-store": "*",
         "magento/module-backend": "*",
         "magento/module-cms": "*",
         "magento/module-catalog": "*",
         "magento/module-config": "*",
         "magento/module-ui": "*",
-        "magento/module-search": "*",
         "magento/module-widget": "*",
         "magento/module-catalog-widget": "*",
         "magento/module-rule": "*",
         "magento/module-directory": "*",
         "php": "~7.1.3||~7.2.0"
     },
+    "suggest": {
+        "magento/module-page-builder-data-migration": "*"
+    },
     "conflict": {
         "gene/bluefoot": "*"
     },

app/code/Magento/PageBuilderDataMigration/Model/Attribute.php

@@ -12,6 +12,8 @@
 
 /**
  * Class Attribute
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Attribute extends \Magento\Eav\Model\Attribute
 {

app/code/Magento/PageBuilderDataMigration/README.md

@@ -1,3 +1,3 @@
 # Magento_PageBuilderDataMigration module
 
-The Magento_PageBuilderDataMigration module provides data migration capabilities from BlueFoot to Page Builder.
+The Magento_PageBuilderDataMigration module provides data migration capabilities from BlueFoot to PageBuilder.

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/ChildrenRendererInterface.php

@@ -17,7 +17,7 @@ interface ChildrenRendererInterface
      * Render children for element
      *
      * @param array $children
-     * @param $renderChildCallback
+     * @param \Closure $renderChildCallback
      *
      * @return string
      */

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/ColorConverter.php

@@ -7,6 +7,9 @@
 
 namespace Magento\PageBuilderDataMigration\Setup\DataConverter;
 
+/**
+ * Class ColorConverter
+ */
 class ColorConverter
 {
     /**

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/ConfigurableEavAttributeLoader.php

@@ -12,6 +12,8 @@
 use Magento\Framework\Exception\NoSuchEntityException;
 
 /**
+ * Class ConfigurableEavAttributeLoader
+ *
  * Using dependency injection, a virtual type can extend this class and be used by your renderer, to configure
  * additional attributes that you want to extract from the EAV during hydration.
  *
@@ -34,6 +36,11 @@ class ConfigurableEavAttributeLoader implements EavAttributeLoaderInterface
      */
     private $attributeFactory;
 
+    /**
+     * @param EntityFactory $entityFactory
+     * @param AttributeFactory $attributeFactory
+     * @param array $additionalEavAttributes
+     */
     public function __construct(
         EntityFactory $entityFactory,
         AttributeFactory $attributeFactory,
@@ -49,6 +56,8 @@ public function __construct(
 
     /**
      * @inheritdoc
+     *
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function load($entityId) : array
     {

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/Renderer/Product.php

@@ -20,6 +20,8 @@
 
 /**
  * Render product to PageBuilder format
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Product implements RendererInterface
 {

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/StyleExtractor.php

@@ -24,6 +24,10 @@ class StyleExtractor implements StyleExtractorInterface
      */
     private $colorConverter;
 
+    /**
+     * @param Json $serializer
+     * @param ColorConverter $colorConverter
+     */
     public function __construct(
         Json $serializer,
         ColorConverter $colorConverter

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/TreeConverter.php

@@ -65,10 +65,9 @@ public function __construct(
     /**
      * Render JSON format to new master format
      *
-     * @param $string
+     * @param string $string
      *
      * @return string
-     * @throws UnableMigrateWithOutParentException
      */
     public function convert(string $string) : string
     {
@@ -86,13 +85,13 @@ public function convert(string $string) : string
     /**
      * Convert content type item
      *
-     * @param $itemData
+     * @param array $itemData
      * @param array $additionalData
      * @param array $children
+     *
      * @return string
-     * @throws UnableMigrateWithOutParentException
      */
-    private function convertTreeItem($itemData, $additionalData = [], $children = [])
+    private function convertTreeItem(array $itemData, array $additionalData = [], array $children = []) : string
     {
         $contentType = isset($itemData['type']) ? $itemData['type'] : $itemData['contentType'];
         $renderer = $this->rendererPool->getRenderer($contentType);
@@ -151,11 +150,14 @@ function ($childItem, $childIndex, $children = []) use ($additionalData) {
      * @param RendererInterface $renderer
      * @param array $itemData
      * @param array $itemAdditionalData
+     *
      * @return string
-     * @throws UnableMigrateWithOutParentException
      */
-    private function processItemRendering($renderer, array $itemData, array $itemAdditionalData = []) : string
-    {
+    private function processItemRendering(
+        RendererInterface $renderer,
+        array $itemData,
+        array $itemAdditionalData = []
+    ) : string {
         $defaultRenderer = $this->rendererPool->getRenderer('default');
 
         try {
@@ -186,8 +188,10 @@ function () use ($itemData) {
     }
 
     /**
-     * Handle render exception. Migrate as html if content type can be migrated without parent,
-     * otherwise throw UnableMigrateWithOutParentException
+     * Handle a render exception
+     *
+     * Migrate as html if content type can be migrated without parent, otherwise throw
+     * UnableMigrateWithOutParentException.
      *
      * @param \Exception $exception
      * @param RendererInterface $defaultRenderer
@@ -212,8 +216,10 @@ private function handleRenderException(
     }
 
     /**
-     * Check whether content type is unseparatable, can not be part of another content type and parent content type
-     * can not contain content types of different type
+     * Check whether content type is un-separatable
+     *
+     * It can not be part of another content type and parent content type can not contain content types of different
+     * type
      *
      * @param array $itemData
      * @return bool

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/Validator.php

@@ -9,6 +9,9 @@
 
 use Magento\Framework\Serialize\Serializer\Json;
 
+/**
+ * Class Validator
+ */
 class Validator
 {
     /**