wip

Author: riccardodallavia

src/Support/Config.php

@@ -4,18 +4,22 @@
 
 class Config
 {
-    protected static \Closure $callback;
+    /**
+     * @var callable|null
+     */
+    protected static $callback;
 
-    public static function resolvePrunableModelsUsing(\Closure $callback)
+    public static function resolvePrunableModelsUsing(?callable $callback): void
     {
         static::$callback = $callback;
     }
 
     public static function getPrunableModels(): array
     {
-        if(isset(static::$callback)) {
+        if (is_callable(static::$callback)) {
             return call_user_func(static::$callback);
         }
+
         return config('prunable-fields.models', []);
     }
 }

tests/MassPrunableFieldsTest.php

@@ -56,17 +56,3 @@
         fn (ModelsFieldsPruned $e) => $e->count === 1 && $e->model === MassPrunableUser::class
     );
 })->with('user_with_mass_prunable_fields');
-
-test('should allow the prunable models to be overridden at runtime', function(MassPrunableUser $model) {
-    \Maize\PrunableFields\Support\Config::resolvePrunableModelsUsing(fn() => [MassPrunableUser::class]);
-    
-    Event::fake();
-
-    pruneFields([]);
-
-    Event::assertDispatched(
-        ModelsFieldsPruned::class,
-        fn (ModelsFieldsPruned $e) => $e->count === 1 && $e->model === MassPrunableUser::class
-    );
-
-})->with('user_with_mass_prunable_fields');

tests/PrunableFieldsTest.php

@@ -3,6 +3,7 @@
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Log;
 use Maize\PrunableFields\Events\ModelsFieldsPruned;
+use Maize\PrunableFields\Support\Config;
 use Maize\PrunableFields\Tests\Events\UserUpdatedEvent;
 use Maize\PrunableFields\Tests\Models\PrunableUser;
 
@@ -67,3 +68,18 @@
         fn (ModelsFieldsPruned $e) => $e->count === 1 && $e->model === PrunableUser::class
     );
 })->with('user_with_prunable_fields');
+
+test('should allow the prunable models to be overridden at runtime', function (PrunableUser $model) {
+    Config::resolvePrunableModelsUsing(fn () => [PrunableUser::class]);
+
+    Event::fake();
+
+    pruneFields([]);
+
+    Event::assertDispatched(
+        ModelsFieldsPruned::class,
+        fn (ModelsFieldsPruned $e) => $e->count === 1 && $e->model === PrunableUser::class
+    );
+
+    Config::resolvePrunableModelsUsing(null);
+})->with('user_with_prunable_fields');