Code cleanup

Author: manami-project

manami-app/src/main/kotlin/io/github/manamiproject/manami/app/commands/GenericReversibleCommand.kt

@@ -49,5 +49,5 @@ internal class GenericReversibleCommand(
 }
 
 private sealed class StatefulSnapshot
-private object Uninitialized : StatefulSnapshot()
+private data object Uninitialized : StatefulSnapshot()
 private data class Initialized(val snapshot: Snapshot) : StatefulSnapshot()

manami-app/src/main/kotlin/io/github/manamiproject/manami/app/commands/history/SimpleEventStream.kt

@@ -63,5 +63,5 @@ internal class SimpleEventStream<T> : EventStream<T> {
 }
 
 private sealed class Events
-private object InitialState : Events()
+private data object InitialState : Events()
 private data class Event<T>(val element: T) : Events()

manami-app/src/main/kotlin/io/github/manamiproject/manami/app/search/SearchHandler.kt

@@ -13,7 +13,7 @@ interface SearchHandler {
 
     fun findSeason(season: AnimeSeason, metaDataProvider: Hostname)
 
-    fun findByTag(tags: Set<Tag>, metaDataProvider: Hostname, searchType: SearchType = AND, status: Set<Anime.Status> = Anime.Status.values().toSet())
+    fun findByTag(tags: Set<Tag>, metaDataProvider: Hostname, searchType: SearchType = AND, status: Set<Anime.Status> = Anime.Status.entries.toSet())
 
     fun findSimilarAnime(uri: URI)
 

manami-app/src/main/kotlin/io/github/manamiproject/manami/app/state/InternalState.kt

@@ -98,5 +98,5 @@ internal object InternalState : State {
 }
 
 internal sealed class OpenedFile
-internal object NoFile : OpenedFile()
+internal data object NoFile : OpenedFile()
 internal data class CurrentFile(val regularFile: RegularFile) : OpenedFile()

manami-gui/src/main/kotlin/io/github/manamiproject/manami/gui/animelist/AnimeForm.kt

@@ -116,7 +116,7 @@ class AnimeForm: Fragment() {
 
                         field("Type") {
                             combobox<String>(selectedType) {
-                                items = FXCollections.observableArrayList(Anime.Type.values().map { it.toString() })
+                                items = FXCollections.observableArrayList(Anime.Type.entries.map { it.toString() })
                                 disableProperty().bindBidirectional(disableTypeProperty)
                             }
                         }

manami-gui/src/main/kotlin/io/github/manamiproject/manami/gui/animelist/SimpleAnimeFormTriggerProperty.kt

@@ -4,7 +4,7 @@ import io.github.manamiproject.manami.gui.animelist.AnimeFormTrigger.CREATE_CUST
 import io.github.manamiproject.modb.core.extensions.EMPTY
 import javafx.beans.property.ObjectPropertyBase
 
-class SimpleAnimeFormTriggerProperty(private var initialValue: AnimeFormTrigger = CREATE_CUSTOM): ObjectPropertyBase<AnimeFormTrigger>(initialValue) {
+class SimpleAnimeFormTriggerProperty(initialValue: AnimeFormTrigger = CREATE_CUSTOM): ObjectPropertyBase<AnimeFormTrigger>(initialValue) {
 
     override fun getBean(): Any = this
     override fun getName(): String = EMPTY

manami-gui/src/main/kotlin/io/github/manamiproject/manami/gui/animelist/SimpleAnimeListEntryProperty.kt

@@ -4,7 +4,7 @@ import io.github.manamiproject.manami.app.lists.animelist.AnimeListEntry
 import io.github.manamiproject.modb.core.extensions.EMPTY
 import javafx.beans.property.ObjectPropertyBase
 
-class SimpleAnimeListEntryProperty(private val initialValue: AnimeListEntry? = null): ObjectPropertyBase<AnimeListEntry>(initialValue) {
+class SimpleAnimeListEntryProperty(initialValue: AnimeListEntry? = null): ObjectPropertyBase<AnimeListEntry>(initialValue) {
 
     override fun getBean(): Any = this
     override fun getName(): String = EMPTY

manami-gui/src/main/kotlin/io/github/manamiproject/manami/gui/animelist/SimpleAnimeProperty.kt

@@ -4,7 +4,7 @@ import io.github.manamiproject.modb.core.extensions.EMPTY
 import io.github.manamiproject.modb.core.models.Anime
 import javafx.beans.property.ObjectPropertyBase
 
-class SimpleAnimeProperty(private val initialValue: Anime? = null): ObjectPropertyBase<Anime>(initialValue) {
+class SimpleAnimeProperty(initialValue: Anime? = null): ObjectPropertyBase<Anime>(initialValue) {
 
     override fun getBean(): Any = this
     override fun getName(): String = EMPTY

manami-gui/src/main/kotlin/io/github/manamiproject/manami/gui/events/GuiEvents.kt

@@ -1,6 +1,5 @@
 package io.github.manamiproject.manami.gui.events
 
-import io.github.manamiproject.manami.app.events.Event
 import io.github.manamiproject.manami.app.inconsistencies.animelist.episodes.EpisodeDiff
 import io.github.manamiproject.manami.app.inconsistencies.animelist.metadata.AnimeListMetaDataDiff
 import io.github.manamiproject.manami.app.lists.Link
@@ -17,7 +16,7 @@ sealed class GuiEvent : FXEvent()
 data class FileOpenedGuiEvent(val fileName: String): GuiEvent()
 data class SavedAsFileGuiEvent(val fileName: String): GuiEvent()
 data class FileSavedStatusChangedGuiEvent(val isFileSaved: Boolean): GuiEvent()
-object CachePopulatorFinishedGuiEvent: GuiEvent()
+data object CachePopulatorFinishedGuiEvent: GuiEvent()
 data class UndoRedoStatusGuiEvent(val isUndoPossible: Boolean, val isRedoPossible: Boolean): GuiEvent()
 data class NewVersionAvailableGuiEvent(val version: SemanticVersion): GuiEvent()
 
@@ -32,7 +31,7 @@ data class RemoveAnimeListEntryGuiEvent(val entries: Set<AnimeListEntry>) : GuiE
 data class AddWatchListEntryGuiEvent(val entries: Set<WatchListEntry>) : GuiEvent()
 data class RemoveWatchListEntryGuiEvent(val entries: Set<WatchListEntry>) : GuiEvent()
 data class AddWatchListStatusUpdateGuiEvent(val finishedTasks: Int, val tasks: Int): GuiEvent()
-object AnimeEntryFinishedGuiEvent: GuiEvent()
+data object AnimeEntryFinishedGuiEvent: GuiEvent()
 
 // IgnoreList
 data class AddIgnoreListEntryGuiEvent(val entries: Set<IgnoreListEntry>) : GuiEvent()
@@ -42,16 +41,16 @@ data class AddIgnoreListStatusUpdateGuiEvent(val finishedTasks: Int, val tasks:
 // Related Anime
 data class AnimeListRelatedAnimeFoundGuiEvent(val anime: Anime): GuiEvent()
 data class AnimeListRelatedAnimeStatusGuiEvent(val finishedChecking: Int, val toBeChecked: Int): GuiEvent()
-object AnimeListRelatedAnimeFinishedGuiEvent: GuiEvent()
+data object AnimeListRelatedAnimeFinishedGuiEvent: GuiEvent()
 
 // IgnoreList Search
 data class IgnoreListRelatedAnimeFoundGuiEvent(val anime: Anime): GuiEvent()
 data class IgnoreListRelatedAnimeStatusGuiEvent(val finishedChecking: Int, val toBeChecked: Int): GuiEvent()
-object IgnoreListRelatedAnimeFinishedGuiEvent: GuiEvent()
+data object IgnoreListRelatedAnimeFinishedGuiEvent: GuiEvent()
 
 // Anime Season
 data class AnimeSeasonEntryFoundGuiEvent(val anime: Anime): GuiEvent()
-object AnimeSeasonSearchFinishedGuiEvent: GuiEvent()
+data object AnimeSeasonSearchFinishedGuiEvent: GuiEvent()
 
 // File Search
 data class FileSearchAnimeListResultsGuiEvent(val anime: Collection<AnimeListEntry>): GuiEvent()
@@ -60,11 +59,11 @@ data class FileSearchIgnoreListResultsGuiEvent(val anime: Collection<IgnoreListE
 
 // Anime Search
 data class AnimeSearchEntryFoundGuiEvent(val anime: Anime): GuiEvent()
-object AnimeSearchFinishedGuiEvent: GuiEvent()
+data object AnimeSearchFinishedGuiEvent: GuiEvent()
 data class AnimeEntryFoundGuiEvent(val anime: Anime): GuiEvent()
 
 // Similar Anime Search
-object SimilarAnimeSearchFinishedGuiEvent: GuiEvent()
+data object SimilarAnimeSearchFinishedGuiEvent: GuiEvent()
 data class SimilarAnimeFoundGuiEvent(val entries: List<Anime>) : GuiEvent()
 
 // Inconsistencies
@@ -74,7 +73,7 @@ data class DeadEntriesInconsistenciesResultGuiEvent(val numberOfAffectedEntries:
 data class AnimeListMetaDataInconsistenciesResultGuiEvent(val diff: AnimeListMetaDataDiff): GuiEvent()
 data class AnimeListDeadEntriesInconsistenciesResultGuiEvent(val entries: Collection<AnimeListEntry>): GuiEvent()
 data class AnimeListEpisodesInconsistenciesResultGuiEvent(val entries: Collection<EpisodeDiff>): GuiEvent()
-object InconsistenciesCheckFinishedGuiEvent: GuiEvent()
+data object InconsistenciesCheckFinishedGuiEvent: GuiEvent()
 
 // Meta Data Provider Migration
 data class MetaDataProviderMigrationGuiEvent(val finishedTasks: Int, val tasks: Int): GuiEvent()

manami-gui/src/main/kotlin/io/github/manamiproject/manami/gui/main/TabPaneView.kt

@@ -74,7 +74,7 @@ class TabPaneView : View() {
         subscribe<ShowSimilarAnimeSearchTabRequest> {
             tabPane.openTab("Similar Anime") { add(similarAnimeSearchView.root) }
         }
-        subscribe<ShowMetaDataProviderMigrationViewTabRequest>() {
+        subscribe<ShowMetaDataProviderMigrationViewTabRequest> {
             tabPane.openTab("Meta Data Provider Migration") { add(metaDataProviderMigrationView.root) }
         }
     }