Skip to content

Update split2 to v4.2.0; remove through2 and replace with Node stream.Transform #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update split2 to v4.2.0; remove through2 and replace with Node stream.Transform #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d92f329
Update `split2` and `through2` to major version 4
kcastellino Feb 5, 2024
b0d6221
Replace `through2` with Node `stream.Transform`
kcastellino Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions concatjson.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict'
const thru = require('through2')
const { Transform } = require('stream')
const split = require('split2')

function parse () {
Expand Down Expand Up @@ -38,13 +38,17 @@ function parse () {
}

function serialize () {
return thru.obj((chunk, enc, cb) => {
return new Serializer({ objectMode: true })
}

class Serializer extends Transform {
_transform (chunk, enc, cb) {
try {
return cb(null, JSON.stringify(chunk))
} catch (err) {
return cb(err)
}
})
}
}

module.exports = {
Expand Down
107 changes: 63 additions & 44 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
"url": "https://github.com/manidlou/concatjson/issues"
},
"homepage": "https://github.com/manidlou/concatjson#readme",
"engines": {
"node": ">= 12.0.0"
},
"dependencies": {
"split2": "^2.1.1",
"through2": "^2.0.3"
"split2": "^4.2.0"
},
"devDependencies": {
"standard": "^8.6.0",
Expand Down