Clarify nature of missing modifier stack object references, AddModifierStack->AddModifierStacks #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AddModifierStack to AddModifierStacks as it adds a range of ModifierStack objects, and identify its parameter as IEnumerable because it only enumerates the given collection
… interface for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apropos of no preexisting issue, for your consideration:
When aggregating ModifierStack objects for VectorLayerVisualizer, it cannot be assumed that all serialized list entries are non-null, as they come from the Editor. Thus, it is benefitial to clarify the reason NullReferenceExceptions are given when iterating over their collection.
Additionally, the AddModifierStack method may add multiple ModifierStack objects, implying that it should be named "AddModifierStacks". Also, it does not need a List to function.
If you have different ideas for the future of AddModifierStack, please close this pull request, and consider the NullReferenceException modification for future scenarios where serialized data is referenced via LINQ or otherwise.
Description of changes
VectorLayerVisualizerObject
VectorLayerVisualizer, IVectorLayerVisualizer
AddModifierStacks(IEnumerable<ModifierStack> stacks)Reviewers
@brnkhy